maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephen Colebourne (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SUREFIRE-1531) Option to switch-off Java 9 modules
Date Fri, 17 Aug 2018 12:49:00 GMT

    [ https://issues.apache.org/jira/browse/SUREFIRE-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16583862#comment-16583862
] 

Stephen Colebourne commented on SUREFIRE-1531:
----------------------------------------------

The PR is basically what I want. Note sure that "disableModules" is clear enough as a property
name though.

The existing plugin also contains the same bug as MJAVADOC-506, namely that excluding the
module-info.java file using configuration does not cause the plugin to ignore it when determining
how to test. ( existsModuleDescriptor() does not take into account file excludes).

> Option to switch-off Java 9 modules
> -----------------------------------
>
>                 Key: SUREFIRE-1531
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1531
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: Maven Surefire Plugin
>    Affects Versions: 2.22.0
>            Reporter: Lukáš Křečan
>            Priority: Major
>
> I am working on a library and I am adding support for Java 9 modules. Surefire 2.21.0
by default executes tests with Java 9 modules switched-on if it detects module-info.java While
it may make sense in some cases, in my case I'd like the switch it off.
> The reason is simple. I am using Mockito to mock an interface that extends a Spring interface.
Mockito has to create an implementation of this interface (proxy or subclass) and for this
it needs to have access to the Spring interfaces. If Java 9 modules are enabled for the tests
I have to manually add each such dependencies to Surefire configuration, which does not make
much sense. To makes things worse, the interface actually extends two Spring interfaces form
two different Spring modules so the configuration is almost impossible to get right.
> So far I am at ( and I am still getting IllegalAccessErrors)
> {code:java}
> --add-exports spring.context/org.springframework.scheduling=org.mockito
> --add-exports spring.beans/org.springframework.beans.factory=org.mockito
> {code}
> I would prefer to switch-off the Java 9 modules for the test module altogether (same
behavior as pre 2.21.0)
>  
> The test is here [https://github.com/lukas-krecan/ShedLock/blob/java9/shedlock-spring/src/test/java/net/javacrumbs/shedlock/spring/CleanupTest.java]
>  
> If you want, I can send a pull request.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message