maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Osipov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SCM-834) Commit encoding is platform-dependent instead of UTF-8
Date Sat, 18 Aug 2018 22:09:00 GMT

    [ https://issues.apache.org/jira/browse/SCM-834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584939#comment-16584939
] 

Michael Osipov commented on SCM-834:
------------------------------------

Just pushed a test branch which does for me. Please test. I want to merge in a week or so.

[~aljane.jamel@gmail.com], please open another issue for your problem.

> Commit encoding is platform-dependent instead of UTF-8
> ------------------------------------------------------
>
>                 Key: SCM-834
>                 URL: https://issues.apache.org/jira/browse/SCM-834
>             Project: Maven SCM
>          Issue Type: Bug
>          Components: maven-scm-provider-gitexe, maven-scm-provider-svn
>    Affects Versions: 1.9.4
>            Reporter: Tobias Gruetzmacher
>            Assignee: Michael Osipov
>            Priority: Blocker
>             Fix For: 1.10.1
>
>
> When doing a release with the maven-release-plugin, if you have a non-ASCII-character
in your commit message (setting scmCommentPrefix to "lösung" for example), the resulting
commit message has a different encoding on different operating systems. If it isn't UTF-8
(on Windows, for example), git complains with
> {code}
> Warning: commit message did not conform to UTF-8.
> You may want to amend it after fixing the message, or set the config
> variable i18n.commitencoding to the encoding your project uses.
> {code}
> AFAICS, the fix is pretty simple: Just add "UTF-8" to the call of fileWrite in [GitCheckInCommand.java|https://github.com/apache/maven-scm/blob/master/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/checkin/GitCheckInCommand.java#L74]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message