maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Osipov (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (SCM-745) Perforce blame result parsing too greedy
Date Sat, 18 Aug 2018 22:47:00 GMT

     [ https://issues.apache.org/jira/browse/SCM-745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael Osipov closed SCM-745.
------------------------------
    Resolution: Fixed

Fixed with [fb4e948aff7f21e77fef669e0364ea4e9afb2f2d|https://gitbox.apache.org/repos/asf?p=maven-scm.git;a=commit;h=fb4e948aff7f21e77fef669e0364ea4e9afb2f2d].

> Perforce blame result parsing too greedy
> ----------------------------------------
>
>                 Key: SCM-745
>                 URL: https://issues.apache.org/jira/browse/SCM-745
>             Project: Maven SCM
>          Issue Type: Bug
>          Components: maven-scm-provider-perforce
>    Affects Versions: 1.8.1, 1.9
>            Reporter: Todd Currie
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: 1.10.1
>
>         Attachments: maven-scm-provider-perforce-blame-auther.patch
>
>
> The regex for the parsing of the author information from the command line results is
incorrect.  It is overly greedy and is consuming additional characters depending upon the
change comments entered by the author.
> org.apache.maven.scm.provider.perforce.command.blame.PerforceFilelogConsumer
> 39c39
> <     private static final String LINE_PATTERN = "#(\\d+).*on (.*) by (.*)@";
> ---
> >     private static final String LINE_PATTERN = "#(\\d+).*?on (.*?) by (.*?)@";
> Example of failure:
> Changelist:	 624405
> Date:	 2013/07/19 14:05
> Client:	 ws_advertising
> User:	 mccabej
> Description:	
> Fix retry order so that the @Retryable proxy always executes first.
> Resulting Author is "mccabej@ws_advertising (ktext) 'Fix retry order so that the "



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message