maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] cardil commented on issue #112: Adding support for externally passed random seed and printing used seed on console
Date Sun, 22 Jul 2018 19:16:44 GMT
cardil commented on issue #112: Adding support for externally passed random seed and printing
used seed on console
URL: https://github.com/apache/maven-surefire/pull/112#issuecomment-406889805
 
 
   Ok. I've manage to fix this bug. Tests are now passing on Linux and Windows on multiple
JDK: Azul, Oracle and OpenJDK.
   
   The error was that test randomization was done on list of loaded classes, but class loading
doesn't provide a contract on order of loading. So, input list was platform dependent. I've
added pre step of sorting input class list. In that way randomization with seed is predictable,
every time on every platform.
   
   https://github.com/apache/maven-surefire/pull/112/files#diff-5bf860cde9189b3ffb9b3e0295282663R42
   
   @Tibor17 please review again

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message