From issues-return-132608-archive-asf-public=cust-asf.ponee.io@maven.apache.org Fri May 11 20:08:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 66353180647 for ; Fri, 11 May 2018 20:08:04 +0200 (CEST) Received: (qmail 4698 invoked by uid 500); 11 May 2018 18:08:03 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 4683 invoked by uid 99); 11 May 2018 18:08:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 May 2018 18:08:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id C2972C0EA8 for ; Fri, 11 May 2018 18:08:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.5 X-Spam-Level: X-Spam-Status: No, score=-109.5 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 886cQy9Dr3Qo for ; Fri, 11 May 2018 18:08:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 30D0A5F24C for ; Fri, 11 May 2018 18:08:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 74EE3E0047 for ; Fri, 11 May 2018 18:08:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3CDD821298 for ; Fri, 11 May 2018 18:08:00 +0000 (UTC) Date: Fri, 11 May 2018 18:08:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@maven.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MNG-6410) When a reactor build fails on an artifactId which is not unique, Maven should provide the groupId when suggesting where build should restart from MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MNG-6410?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D164723= 83#comment-16472383 ]=20 ASF GitHub Bot commented on MNG-6410: ------------------------------------- splatch opened a new pull request #166: [MNG-6410] Clean suggestion on buil= d resume. URL: https://github.com/apache/maven/pull/166 =20 =20 Make sure that resume suggestion contains a valid value for restarting t= he build, as same artifact name might occur in different places of multi-mo= dule project, it is necessary to check if there is conflict in name. =20 By this way returned suggestion will always be correct and less experien= ced developers will not get confused with it. =20 JIRA issue: https://issues.apache.org/jira/browse/MNG-6410. A extra note, this pull request depends on another pull #165 - for MNG-6= 028, which changes the same line, both commits are included in this PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > When a reactor build fails on an artifactId which is not unique, Maven sh= ould provide the groupId when suggesting where build should restart from > -------------------------------------------------------------------------= ------------------------------------------------------------------------ > > Key: MNG-6410 > URL: https://issues.apache.org/jira/browse/MNG-6410 > Project: Maven > Issue Type: Bug > Components: Command Line > Affects Versions: 3.5.3 > Reporter: =C5=81ukasz Dywicki > Priority: Minor > > In multi module builds same artifact id can be repeated with different gr= oup id. For example if project strategy is to use nesting of modules, inste= ad of using long artifact names, {{ap}} or {{model}} module can occur multi= ple times with different group id. > By default maven, upon failed build, prints out only {{-rf :artifactId}}.= When developer will copy given suggestion and run build again then his bui= ld will be started from first module which have given artifact id. > While severity of this bug is quite low, it affects productivity in bigge= r projects big time. To improve usability of returned message a Maven shoul= d return {{-rf groupId:artifactId}} once artifact id is not unique. -- This message was sent by Atlassian JIRA (v7.6.3#76005)