From issues-return-132084-archive-asf-public=cust-asf.ponee.io@maven.apache.org Tue May 1 16:11:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2D5A9180645 for ; Tue, 1 May 2018 16:11:04 +0200 (CEST) Received: (qmail 65517 invoked by uid 500); 1 May 2018 14:11:03 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 65506 invoked by uid 99); 1 May 2018 14:11:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 May 2018 14:11:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 962EB18048A for ; Tue, 1 May 2018 14:11:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id EQqjLyehk1ny for ; Tue, 1 May 2018 14:11:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 2481D5F5B1 for ; Tue, 1 May 2018 14:11:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 60444E02F1 for ; Tue, 1 May 2018 14:11:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1018A21293 for ; Tue, 1 May 2018 14:11:00 +0000 (UTC) Date: Tue, 1 May 2018 14:11:00 +0000 (UTC) From: "Ilya Basin (JIRA)" To: issues@maven.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SCM-869) gitexe list() implemented incorrectly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SCM-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16459705#comment-16459705 ] Ilya Basin commented on SCM-869: -------------------------------- First of all, the JGit provider needs to be upgraded for the newer jgit, because the current version requires the git binary for some operations. > gitexe list() implemented incorrectly > ------------------------------------- > > Key: SCM-869 > URL: https://issues.apache.org/jira/browse/SCM-869 > Project: Maven SCM > Issue Type: Bug > Components: maven-scm-provider-gitexe > Affects Versions: 1.9.5, 1.9.6 > Reporter: Ilya Basin > Assignee: Michael Osipov > Priority: Major > Fix For: 1.9.6 > > > Taking the Svn implementation as a model, ScmProvider.list() should be implemented as follows: > * The command must directly query the remote repository for files > * A local working copy is unnecessary and if it doesn't exist, the remote repository must not be checked out. > * fileSet.getBasedir() indicates where to run the scm binary. The recommended value is ".". > * fileSet.getFileList() indicates the files to list > * repository indicates the repo URL > Git (among other SCMs) does not support listing remote files, so the command should just fail. > For listing files in a working copy, users should call the ScmProvider.status() method instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)