maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SCM-885) GitChangeLogCommand is wrong when only endVersion is set
Date Wed, 16 May 2018 20:18:00 GMT

    [ https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478034#comment-16478034
] 

ASF GitHub Bot commented on SCM-885:
------------------------------------

michael-o commented on a change in pull request #72: [SCM-885] second implementation with
new API
URL: https://github.com/apache/maven-scm/pull/72#discussion_r188758228
 
 

 ##########
 File path: maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogCommand.java
 ##########
 @@ -89,17 +102,28 @@ protected ChangeLogScmResult executeChangeLogCommand( ChangeLogScmRequest
reques
         final String datePattern = request.getDatePattern();
         return executeChangeLogCommand( request.getScmRepository().getProviderRepository(),
fileSet,
             request.getStartDate(), request.getEndDate(), request.getScmBranch(), datePattern,
startVersion,
-                endVersion, request.getLimit() );
+                endVersion, request.getLimit(), request.getStartFromRoot() );
     }
 
     protected ChangeLogScmResult executeChangeLogCommand( ScmProviderRepository repo, ScmFileSet
fileSet,
                                                           Date startDate, Date endDate, ScmBranch
branch,
                                                           String datePattern, ScmVersion
startVersion,
                                                           ScmVersion endVersion, Integer
limit )
+            throws ScmException
 
 Review comment:
   4 char

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> GitChangeLogCommand is wrong when only endVersion is set
> --------------------------------------------------------
>
>                 Key: SCM-885
>                 URL: https://issues.apache.org/jira/browse/SCM-885
>             Project: Maven SCM
>          Issue Type: Bug
>          Components: maven-scm-provider-gitexe
>    Affects Versions: 1.9.5
>            Reporter: Matthieu Brouillard
>            Priority: Major
>             Fix For: waiting-for-feedback
>
>         Attachments: scm-885-different-behavior-exe-jgit-patch.diff
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has been set
produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso  ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso  END_REVISION_SHA1 -- PROJECT_PATH}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message