maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vishal Kumar Gupta <groups...@gmail.com>
Subject Re: [GitHub] michael-o commented on a change in pull request #74: [SCM-885] third implementation
Date Fri, 18 May 2018 20:14:15 GMT
michael-o commented on a change in pull request #74: [SCM-885] third
implementation
URL: https://github.com/apache/maven-scm/pull/74#discussion_r189381717



 ##########
 File path: maven-scm-providers/maven-scm-providers-git/maven-scm-
provider-gitexe/src/main/java/org/apache/maven/scm/provider/
git/gitexe/command/changelog/GitChangeLogCommand.java
 ##########
 @@ -136,9 +155,18 @@ public static Commandline createCommandLine(
GitScmProviderRepository repository
                                   null );
     }

+    static Commandline createCommandLine( GitScmProviderRepository
repository, File workingDirectory,
+                                          ScmBranch branch, Date
startDate, Date endDate,
+                                          ScmVersion startVersion,
ScmVersion endVersion, Integer limit)
+    {
+        return createCommandLine( repository, workingDirectory, branch,
startDate, endDate, startVersion, endVersion,
+                            limit, null );

 Review comment:
   indent continuation

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services



On Sat, May 19, 2018 at 1:42 AM, GitBox <git@apache.org> wrote:

> michael-o commented on a change in pull request #74: [SCM-885] third
> implementation
> URL: https://github.com/apache/maven-scm/pull/74#discussion_r189381637
>
>
>
>  ##########
>  File path: maven-scm-providers/maven-scm-providers-git/maven-scm-
> provider-gitexe/src/main/java/org/apache/maven/scm/provider/
> git/gitexe/command/changelog/GitChangeLogCommand.java
>  ##########
>  @@ -69,14 +69,22 @@ protected ChangeLogScmResult executeChangeLogCommand(
> ScmProviderRepository repo
>          return executeChangeLogCommand( repo, fileSet, startDate,
> endDate, branch, datePattern, null, null );
>      }
>
> -    protected ChangeLogScmResult executeChangeLogCommand(
> ScmProviderRepository repo, ScmFileSet fileSet,
> -                                                          Date startDate,
> Date endDate, ScmBranch branch,
> -                                                          String
> datePattern, ScmVersion startVersion,
> -                                                          ScmVersion
> endVersion )
> +    @Override
> +    protected ChangeLogScmResult executeChangeLogCommand(
> ScmProviderRepository repository, ScmFileSet fileSet,
> +                                                          ScmVersion
> version, String datePattern)
> +        throws ScmException
> +    {
> +        return executeChangeLogCommand( repository, fileSet, null, null,
> null, datePattern, null, null, null, version );
> +    }
> +
> +    protected ChangeLogScmResult executeChangeLogCommand(ScmProviderRepository
> repo, ScmFileSet fileSet,
>
>  Review comment:
>    space please.
>
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
> With regards,
> Apache Git Services
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message