maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] olamy commented on a change in pull request #186: Fixing build on master branch
Date Sun, 27 May 2018 00:44:25 GMT
olamy commented on a change in pull request #186: Fixing build on master branch
URL: https://github.com/apache/maven-surefire/pull/186#discussion_r191061714
 
 

 ##########
 File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/Utf8RecodingDeferredFileOutputStream.java
 ##########
 @@ -42,7 +42,7 @@
     private boolean closed = false;
 
     @SuppressWarnings( "checkstyle:magicnumber" )
-    public Utf8RecodingDeferredFileOutputStream( String channel )
+    Utf8RecodingDeferredFileOutputStream( String channel )
 
 Review comment:
   why removing public constructor this is not backward compat???? if checkstyle complains
about this so remove checkstyle usage as it's useless....

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message