From issues-return-131292-archive-asf-public=cust-asf.ponee.io@maven.apache.org Tue Apr 10 00:29:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D5BCA180645 for ; Tue, 10 Apr 2018 00:29:04 +0200 (CEST) Received: (qmail 73766 invoked by uid 500); 9 Apr 2018 22:29:03 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 73603 invoked by uid 99); 9 Apr 2018 22:29:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Apr 2018 22:29:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id A274AC03DE for ; Mon, 9 Apr 2018 22:29:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id hVHkpaJ11SR3 for ; Mon, 9 Apr 2018 22:29:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 39E025FAEC for ; Mon, 9 Apr 2018 22:29:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id CA5D5E0B9E for ; Mon, 9 Apr 2018 22:29:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4B6F9241CB for ; Mon, 9 Apr 2018 22:29:00 +0000 (UTC) Date: Mon, 9 Apr 2018 22:29:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@maven.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SUREFIRE-1378) Nice to have systemPropertiesFile configurable by user property MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SUREFIRE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431413#comment-16431413 ] ASF GitHub Bot commented on SUREFIRE-1378: ------------------------------------------ Tibor17 commented on a change in pull request #152: [SUREFIRE-1378] Nice to have systemPropertiesFile configurable by user property URL: https://github.com/apache/maven-surefire/pull/152#discussion_r180249519 ########## File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java ########## @@ -1033,11 +1025,11 @@ private SurefireProperties setupProperties() SurefireProperties sysProps = null; try { - sysProps = SurefireProperties.loadProperties( systemPropertiesFile ); + sysProps = SurefireProperties.loadProperties(getSystemPropertiesFile()); } catch ( IOException e ) { - String msg = "The system property file '" + systemPropertiesFile.getAbsolutePath() + "' can't be read."; + String msg = "The system property file '" + getSystemPropertiesFile().getAbsolutePath() + "' can't be read."; Review comment: `+` at new line ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > Nice to have systemPropertiesFile configurable by user property > --------------------------------------------------------------- > > Key: SUREFIRE-1378 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1378 > Project: Maven Surefire > Issue Type: Improvement > Components: Maven Failsafe Plugin, Maven Surefire Plugin > Reporter: Michal Domagala > Assignee: Tibor Digana > Priority: Minor > > I would like to have option to configure my tests with property files. But property file is not required, because in 95% my tests work fine with default configuration. > I used the following workaround: I configured failsafe plugin in the following way > {code:xml} > > > > (...) > maven-failsafe-plugin > (...) > ${my.test.props.file} > {code} > In 95% I call *mvn verify*, systemPropertiesFile is not found and ignored -all pass > In 5% I call *mvn verify -Dmy.test.props.file=x.props* > The problem is in 95% I get warning about missing files. Also configuration is unnecessary complicated > I would like drop whole connfiguration from pom.xml and use: > In 95% *mvn verify* > In 5% *mvn verify -Dfailsafe.systemPropertiesFile=x.props* -- This message was sent by Atlassian JIRA (v7.6.3#76005)