From issues-return-129369-archive-asf-public=cust-asf.ponee.io@maven.apache.org Fri Mar 16 11:13:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id F18CB180608 for ; Fri, 16 Mar 2018 11:13:03 +0100 (CET) Received: (qmail 47652 invoked by uid 500); 16 Mar 2018 10:13:03 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 47641 invoked by uid 99); 16 Mar 2018 10:13:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Mar 2018 10:13:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 6E64EC12C7 for ; Fri, 16 Mar 2018 10:13:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 3Kqc3DSIDaOU for ; Fri, 16 Mar 2018 10:13:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 1AFEF5F2F0 for ; Fri, 16 Mar 2018 10:13:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5DE85E0185 for ; Fri, 16 Mar 2018 10:13:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2272321280 for ; Fri, 16 Mar 2018 10:13:00 +0000 (UTC) Date: Fri, 16 Mar 2018 10:13:00 +0000 (UTC) From: "Robert Scholte (JIRA)" To: issues@maven.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SUREFIRE-1501) Optional dependencies not correctly handled with JPMS modules MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SUREFIRE-1501?page=3Dcom.atlass= ian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1= 6401707#comment-16401707 ]=20 Robert Scholte commented on SUREFIRE-1501: ------------------------------------------ IIUC the fix should be: all static required modules should result in an ext= ra argument: {{--add-modules X}}=C2=A0 > Optional dependencies not correctly handled with JPMS modules > ------------------------------------------------------------- > > Key: SUREFIRE-1501 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1501 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin > Affects Versions: 2.21.0 > Environment: Windows 10, Maven v3.5.2 > Reporter: Stephen Colebourne > Priority: Major > Attachments: maven-issue1.zip > > > Attached=C2=A0is a pointlessly simple project for Java 9. The module-info= declares an=C2=A0_optional_ dependency on Google Guava (an automatic modul= e) using _requires static_. This optionality is reflected in the pom.xml, w= here the dependency is marked as optional. > It=C2=A0fails in surefire with JAVA_HOME=3Djdk9. The reason seems to be t= hat although the Guava jar file is added to the modulepath,=C2=A0it is not = referenced using --add-modules.=C2=A0As such, the module graph builder neve= r pulls it in, despite it being on the modulepath. (Optional dependencies n= eed to be directly added using --add-modules if in Maven's dependency graph= ) > Adding the --add-modules to the `argLine` parameter solves the problem, b= ut this is a bug because the surefire plugin should handle the situation wi= thout manually adding it. > NOTE! The attachment has the --add-modules manually added to the=C2=A0pom= .xml. Remove it to see the bug. -- This message was sent by Atlassian JIRA (v7.6.3#76005)