From issues-return-128753-archive-asf-public=cust-asf.ponee.io@maven.apache.org Sat Mar 3 17:43:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 69DBE180654 for ; Sat, 3 Mar 2018 17:43:04 +0100 (CET) Received: (qmail 90281 invoked by uid 500); 3 Mar 2018 16:43:03 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 90269 invoked by uid 99); 3 Mar 2018 16:43:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 03 Mar 2018 16:43:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id C8F99C00D7 for ; Sat, 3 Mar 2018 16:43:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.51 X-Spam-Level: X-Spam-Status: No, score=-109.51 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, KAM_SHORT=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id IEpkdIEyZ91W for ; Sat, 3 Mar 2018 16:43:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 8B67B5F4AE for ; Sat, 3 Mar 2018 16:43:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B9880E02F0 for ; Sat, 3 Mar 2018 16:43:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2AD1321265 for ; Sat, 3 Mar 2018 16:43:00 +0000 (UTC) Date: Sat, 3 Mar 2018 16:43:00 +0000 (UTC) From: "Hudson (JIRA)" To: issues@maven.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MPH-87) help:effective-pom/effective-settings uses platform encoding and garbles non-ASCII characters, emits invalid XML MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MPH-87?page=3Dcom.atlassian.jir= a.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16384730= #comment-16384730 ]=20 Hudson commented on MPH-87: --------------------------- Build succeeded in Jenkins: Maven TLP =C2=BB maven-help-plugin =C2=BB maste= r #6 See https://builds.apache.org/job/maven-box/job/maven-help-plugin/job/maste= r/6/ > help:effective-pom/effective-settings uses platform encoding and garbles = non-ASCII characters, emits invalid XML > -------------------------------------------------------------------------= --------------------------------------- > > Key: MPH-87 > URL: https://issues.apache.org/jira/browse/MPH-87 > Project: Maven Help Plugin > Issue Type: Bug > Components: effective-pom > Affects Versions: 2.1.1 > Environment: Windows, MacOSX, Linux, Maven 3.0.4 > Reporter: Mirko Friedenhagen > Assignee: Michael Osipov > Priority: Major > Fix For: 3.0.0 > > Attachments: mfriedenhagen-invalidpom-MPH-87-0-g42a5c31.zip > > > As stated in http://www.w3.org/TR/REC-xml/#sec-guessing-no-ext-info XML f= iles without a BOM and without a XML encoding declaration should read the X= ML as UTF-8.=20 > {{help:effective-pom}} does use the platform encoding for writing the eff= ective-pom without emitting an appropriate XML encoding declaration in the = resulting XML file. > I have created a small sample project (available at https://github.com/mf= riedenhagen/invalidpom, attached as ZIP) which will reproduce the issue. > While the parent pom (https://raw.github.com/mfriedenhagen/invalidpom/mas= ter/pom.xml) has a XML encoding declaration, https://raw.github.com/mfriede= nhagen/invalidpom/master/child-invalid/pom.xml has none. > Now running: > {code} > mvn -s settings.xml -gs settings.xml clean validate > {code} > will produce an invalid character for the developer name "J=C3=83=C2=B6rg= " in {{child-invalid}}.=20 > Two workarounds are: > * to include a XML encoding declaration as done in {{child-valid}}.=20 > * to use {{JAVA_TOOL_OPTIONS}} on Windows as stated in http://stackoverfl= ow.com/a/623036/49132 > * to use {{MAVEN_OPTS=3D-Dfile.encoding=3Dutf-8 mvn -s settings.xml -gs s= ettings.xml clean validate}}. > Nonetheless I consider this a Major bug, as it clearly violates the recom= mendations of W3C. -- This message was sent by Atlassian JIRA (v7.6.3#76005)