maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Osipov (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SCM-877) AbstractSvnScmProvider#parseScmUrl() accepts file URLs with backslashes while SvnTagBranchUtils cannot handle them
Date Fri, 30 Mar 2018 00:42:00 GMT

     [ https://issues.apache.org/jira/browse/SCM-877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael Osipov updated SCM-877:
-------------------------------
    Description: 
Subversion accepts URLs in the form:
{noformat}
svn co file:///D:\my\repo{noformat}
While this URL is invalid, it is still parsed properly. Using the same URL in {{<developerConnection
/>}} makes SvnTagBranchUtils completely fail in path calculation because it does not handle
backslashes at all.

 

The proposed solution is that {{parseUrl()}} will test file URLs for backslashes and reject
them since they are invalid aynway.

  was:
Subversion accepts URLs in the form:
{noformat}
svn co file:///D:\my\repo{noformat}
While this URL is invalid, it is still parsed properly. Using the same URL in {{<developerConnection
/>}} makes SvnTagBranchUtils completely fail in path calculation because it does not handle
backslashes at all.

 

The proposed solution is that {{parseUrl()}} will test file URLs for backslashes and reject
them.


> AbstractSvnScmProvider#parseScmUrl() accepts file URLs with backslashes while SvnTagBranchUtils
cannot handle them
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: SCM-877
>                 URL: https://issues.apache.org/jira/browse/SCM-877
>             Project: Maven SCM
>          Issue Type: Bug
>          Components: maven-scm-provider-svn
>    Affects Versions: 1.9.5
>            Reporter: Michael Osipov
>            Priority: Major
>             Fix For: 1.9.6
>
>
> Subversion accepts URLs in the form:
> {noformat}
> svn co file:///D:\my\repo{noformat}
> While this URL is invalid, it is still parsed properly. Using the same URL in {{<developerConnection
/>}} makes SvnTagBranchUtils completely fail in path calculation because it does not handle
backslashes at all.
>  
> The proposed solution is that {{parseUrl()}} will test file URLs for backslashes and
reject them since they are invalid aynway.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message