maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MPH-87) help:effective-pom/effective-settings uses platform encoding and garbles non-ASCII characters, emits invalid XML
Date Sat, 03 Mar 2018 16:43:00 GMT

    [ https://issues.apache.org/jira/browse/MPH-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16384730#comment-16384730
] 

Hudson commented on MPH-87:
---------------------------

Build succeeded in Jenkins: Maven TLP » maven-help-plugin » master #6

See https://builds.apache.org/job/maven-box/job/maven-help-plugin/job/master/6/

> help:effective-pom/effective-settings uses platform encoding and garbles non-ASCII characters,
emits invalid XML
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: MPH-87
>                 URL: https://issues.apache.org/jira/browse/MPH-87
>             Project: Maven Help Plugin
>          Issue Type: Bug
>          Components: effective-pom
>    Affects Versions: 2.1.1
>         Environment: Windows, MacOSX, Linux, Maven 3.0.4
>            Reporter: Mirko Friedenhagen
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: 3.0.0
>
>         Attachments: mfriedenhagen-invalidpom-MPH-87-0-g42a5c31.zip
>
>
> As stated in http://www.w3.org/TR/REC-xml/#sec-guessing-no-ext-info XML files without
a BOM and without a XML encoding declaration should read the XML as UTF-8. 
> {{help:effective-pom}} does use the platform encoding for writing the effective-pom without
emitting an appropriate XML encoding declaration in the resulting XML file.
> I have created a small sample project (available at https://github.com/mfriedenhagen/invalidpom,
attached as ZIP) which will reproduce the issue.
> While the parent pom (https://raw.github.com/mfriedenhagen/invalidpom/master/pom.xml)
has a XML encoding declaration, https://raw.github.com/mfriedenhagen/invalidpom/master/child-invalid/pom.xml
has none.
> Now running:
> {code}
> mvn -s settings.xml -gs settings.xml clean validate
> {code}
> will produce an invalid character for the developer name "Jörg" in {{child-invalid}}.

> Two workarounds are:
> * to include a XML encoding declaration as done in {{child-valid}}. 
> * to use {{JAVA_TOOL_OPTIONS}} on Windows as stated in http://stackoverflow.com/a/623036/49132
> * to use {{MAVEN_OPTS=-Dfile.encoding=utf-8 mvn -s settings.xml -gs settings.xml clean
validate}}.
> Nonetheless I consider this a Major bug, as it clearly violates the recommendations of
W3C.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message