maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SCM-863) NPE in GlobalOptions.setCVSRoot(null) with newer cvsclient
Date Fri, 16 Feb 2018 11:43:00 GMT

    [ https://issues.apache.org/jira/browse/SCM-863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366888#comment-16366888
] 

ASF GitHub Bot commented on SCM-863:
------------------------------------

GitHub user basinilya opened a pull request:

    https://github.com/apache/maven-scm/pull/61

    [SCM-863] fix NPE in GlobalOptions.setCVSRoot(null) with newer cvsclient

    http://hg.netbeans.org/releases/file/91d6c4c73bea/lib.cvsclient/src/org/netbeans/lib/cvsclient/command/GlobalOptions.java#l467

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/basinilya/maven-scm SCM-863

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven-scm/pull/61.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #61
    
----
commit fa78bbc6d4e93ecc218f245df24c3b674023a25c
Author: Ilya Basin <basinilya@...>
Date:   2018-02-13T14:24:30Z

    [SCM-863] fix NPE in GlobalOptions.setCVSRoot(null) with newer cvsclient
    
    http://hg.netbeans.org/releases/file/91d6c4c73bea/lib.cvsclient/src/org/netbeans/lib/cvsclient/command/GlobalOptions.java#l467

----


> NPE in GlobalOptions.setCVSRoot(null) with newer cvsclient
> ----------------------------------------------------------
>
>                 Key: SCM-863
>                 URL: https://issues.apache.org/jira/browse/SCM-863
>             Project: Maven SCM
>          Issue Type: Bug
>          Components: maven-scm-provider-cvs
>    Affects Versions: 1.9.5, 1.9.6
>            Reporter: Ilya Basin
>            Priority: Minor
>
> I'm running mvn test on Windows with CVSNT 2.5.03.2382 installed. To test another bug
I upgraded the cvsclient dependency to the Tip of the Netbeans Mercurial repo (created a local
maven artifact for that).
> My command line is:
> mvn test -DcvsClientLog=system -Dtest=CvsJavaChangeLogCommandTest#testGetCommandWithBranchOrTag
> The test is failing with:
> {code:java}
> Running org.apache.maven.scm.provider.cvslib.cvsjava.command.changelog.CvsJavaChangeLogCommandTest
> Test command line: cmd.exe /X /C "cvs -f -d C:\progs\maven\maven-scm\maven-scm-providers\maven-scm-providers-cvs\maven-scm-provider-cvsjava\src\test\repository
> co test-repo/changelog"
> [INFO] Executing: cmd.exe /X /C "cvs -z3 -f -d :local:C:\progs\maven\maven-scm\maven-scm-providers\maven-scm-providers-cvs\maven-scm-provider-cvsjava\src\test\r
> epository -q log -r1.107.4"
> [INFO] Working directory: C:\progs\maven\maven-scm\maven-scm-providers\maven-scm-providers-cvs\maven-scm-provider-cvsjava\target\scm-test\working-copy
> java.lang.NullPointerException
>         at org.netbeans.lib.cvsclient.CVSRoot.<init>(CVSRoot.java:239)
>         at org.netbeans.lib.cvsclient.CVSRoot.parse(CVSRoot.java:159)
>         at org.netbeans.lib.cvsclient.command.GlobalOptions.setCVSRoot(GlobalOptions.java:468)
>         at org.apache.maven.scm.provider.cvslib.cvsjava.util.CvsConnection.processCommand(CvsConnection.java:406)
>         at org.apache.maven.scm.provider.cvslib.cvsjava.command.changelog.CvsJavaChangeLogCommand.executeCvsCommand(CvsJavaChangeLogCommand.java:55)
>         at org.apache.maven.scm.provider.cvslib.command.changelog.AbstractCvsChangeLogCommand.executeChangeLogCommand(AbstractCvsChangeLogCommand.java:124)
>         at org.apache.maven.scm.provider.cvslib.command.changelog.AbstractCvsChangeLogCommand.executeChangeLogCommand(AbstractCvsChangeLogCommand.java:64)
>         at org.apache.maven.scm.command.changelog.AbstractChangeLogCommand.executeCommand(AbstractChangeLogCommand.java:114)
>         at org.apache.maven.scm.command.AbstractCommand.execute(AbstractCommand.java:59)
>         at org.apache.maven.scm.provider.cvslib.AbstractCvsScmProvider.executeCommand(AbstractCvsScmProvider.java:769)
>         at org.apache.maven.scm.provider.cvslib.AbstractCvsScmProvider.changelog(AbstractCvsScmProvider.java:282)
>         at org.apache.maven.scm.provider.AbstractScmProvider.changeLog(AbstractScmProvider.java:295)
>         at org.apache.maven.scm.provider.AbstractScmProvider.changeLog(AbstractScmProvider.java:283)
>         at org.apache.maven.scm.provider.AbstractScmProvider.changeLog(AbstractScmProvider.java:257)
>         at org.apache.maven.scm.provider.AbstractScmProvider.changeLog(AbstractScmProvider.java:239)
>         at org.apache.maven.scm.provider.cvslib.command.changelog.CvsChangeLogCommandTest.testChangeLog(CvsChangeLogCommandTest.java:90)
>         at org.apache.maven.scm.provider.cvslib.command.changelog.CvsChangeLogCommandTest.testGetCommandWithBranchOrTag(CvsChangeLogCommandTest.java:71)
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>         at java.lang.reflect.Method.invoke(Method.java:606)
>         at junit.framework.TestCase.runTest(TestCase.java:176)
>         at junit.framework.TestCase.runBare(TestCase.java:141)
>         at junit.framework.TestResult$1.protect(TestResult.java:122)
>         at junit.framework.TestResult.runProtected(TestResult.java:142)
>         at junit.framework.TestResult.run(TestResult.java:125)
>         at junit.framework.TestCase.run(TestCase.java:129)
>         at junit.framework.TestSuite.runTest(TestSuite.java:255)
>         at junit.framework.TestSuite.run(TestSuite.java:250)
>         at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84)
>         at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:367)
>         at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:274)
>         at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
>         at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:161)
>         at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:290)
>         at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:242)
>         at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:121{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message