maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gordon Pettey (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (MASSEMBLY-775) Emit WARNING instead of ERROR
Date Wed, 21 Feb 2018 18:54:00 GMT

    [ https://issues.apache.org/jira/browse/MASSEMBLY-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16371826#comment-16371826
] 

Gordon Pettey edited comment on MASSEMBLY-775 at 2/21/18 6:53 PM:
------------------------------------------------------------------

It's not checking "a path starting with / on a Windows system". Every one of those checks
is for the *destination* path. It's checking a path starting with / as the target path in
the assembled archive, which is utter nonsense. The zip/tar/whatever file isn't ever going
to have "Windows" paths with drive letters in it (and if you supplied one as a target path,
I suspect the archiver code is going to barf an exception at you - no need to duplicate a
check in the assembly plugin). {{/}} is the appropriate way to specify the root directory
of the target archive.


was (Author: gpettey):
It's not checking "a path starting with / on a Windows system". It's checking a path starting
with / as the target path in the assembled archive, which is utter nonsense. The zip/tar/whatever
file isn't ever going to have "Windows" paths with drive letters in it. {{/}} is the appropriate
way to specify the root directory of the archive.

> Emit WARNING instead of ERROR
> -----------------------------
>
>                 Key: MASSEMBLY-775
>                 URL: https://issues.apache.org/jira/browse/MASSEMBLY-775
>             Project: Maven Assembly Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.5.5
>            Reporter: Karl Heinz Marbaise
>            Priority: Minor
>
> I have currently a build which creates several tar/tar.gz/zip archives etc.
> {code}
> [INFO] Reading assembly descriptor: src/main/assembly/descriptor-inner-tar.xml
> [INFO] Reading assembly descriptor: src/main/assembly/descriptor.xml
> [INFO] Building tar: C:\...\xyz-X.y.z-SNAPSHOT-dist.tar
> [ERROR] OS=Windows and the assembly descriptor contains a *nix-specific root-relative-reference
(starting with slash) /
> [ERROR] OS=Windows and the assembly descriptor contains a *nix-specific root-relative-reference
(starting with slash) /
> {code}
> In my opinion the message could be a WARNING instead of an error ? WDYT ?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message