From issues-return-126965-archive-asf-public=cust-asf.ponee.io@maven.apache.org Thu Jan 4 10:25:07 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id A600D180657 for ; Thu, 4 Jan 2018 10:25:07 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 95D03160C2B; Thu, 4 Jan 2018 09:25:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DBBA2160C28 for ; Thu, 4 Jan 2018 10:25:06 +0100 (CET) Received: (qmail 56064 invoked by uid 500); 4 Jan 2018 09:25:06 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 56053 invoked by uid 99); 4 Jan 2018 09:25:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Jan 2018 09:25:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 8F05D180799 for ; Thu, 4 Jan 2018 09:25:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -107.211 X-Spam-Level: X-Spam-Status: No, score=-107.211 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id QrS4HxWJVwf0 for ; Thu, 4 Jan 2018 09:25:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id DD6055F3E1 for ; Thu, 4 Jan 2018 09:25:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 722AFE0662 for ; Thu, 4 Jan 2018 09:25:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2BC91212F7 for ; Thu, 4 Jan 2018 09:25:00 +0000 (UTC) Date: Thu, 4 Jan 2018 09:25:00 +0000 (UTC) From: "Peter Palaga (JIRA)" To: issues@maven.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MPLUGIN-331) Check the existence of plugin.xml rather than project packaging in PluginReport.canGenerateReport() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MPLUGIN-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311069#comment-16311069 ] Peter Palaga commented on MPLUGIN-331: -------------------------------------- [~hboutemy], I assumed this fix is not going to be available in 3.5.* because it is a new feature rather than a fix. That's why I used {{@since 3.6}} in https://github.com/apache/maven-plugin-tools/pull/10/commits/4537b92fdb8dec01300ee61a1a97baa2ae5d1a41#diff-a72a02035d1c1407a6e5cc6a911a648dR203 Should I change it to 3.5.1? > Check the existence of plugin.xml rather than project packaging in PluginReport.canGenerateReport() > --------------------------------------------------------------------------------------------------- > > Key: MPLUGIN-331 > URL: https://issues.apache.org/jira/browse/MPLUGIN-331 > Project: Maven Plugin Tools > Issue Type: Task > Components: Plugin Plugin > Reporter: Peter Palaga > Fix For: 3.5.1 > > > {{org.apache.maven.plugin.plugin.PluginReport.canGenerateReport()}} currently reads > {code} > return "maven-plugin".equals( project.getPackaging() ); > {code} > I propose to change it to > {code} > return "maven-plugin".equals( project.getPackaging() ) > || "takari-maven-plugin".equals( project.getPackaging() ); > {code} > so that also takari-maven-plugins are supported. -- This message was sent by Atlassian JIRA (v6.4.14#64029)