maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MPLUGIN-331) Check the existence of plugin.xml rather than project packaging in PluginReport.canGenerateReport()
Date Thu, 11 Jan 2018 12:34:00 GMT

    [ https://issues.apache.org/jira/browse/MPLUGIN-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322145#comment-16322145
] 

ASF GitHub Bot commented on MPLUGIN-331:
----------------------------------------

ppalaga commented on issue #10: [MPLUGIN-331] Let plugin:report support takari-maven-plugin
packaging
URL: https://github.com/apache/maven-plugin-tools/pull/10#issuecomment-356921328
 
 
   @hboutemy @rfscholte sorry for the late response. I have to admit, I have envisaged the
configurable `pluginXmlFile` to eventually be able to use an alternative `plugin.xml` only
to produce the site during a release and keep using takari-lifecycle-plugin for jar. The takari-lifecycle-plugin
produces an imperfect `plugin.xml` (see [1]) and the shortages matter only during the site
production. This being only an initial idea rather than a proven solution how to fix my situation,
I agree to either make the param readonly or remove the param altogether and hard code the
plugin.xml path instead. Thanks for your patience.
   
   [1] https://github.com/takari/takari-lifecycle/issues/63

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Check the existence of plugin.xml rather than project packaging in PluginReport.canGenerateReport()
> ---------------------------------------------------------------------------------------------------
>
>                 Key: MPLUGIN-331
>                 URL: https://issues.apache.org/jira/browse/MPLUGIN-331
>             Project: Maven Plugin Tools
>          Issue Type: Task
>          Components: Plugin Plugin
>            Reporter: Peter Palaga
>            Assignee: Hervé Boutemy
>             Fix For: 3.5.1
>
>
> {{org.apache.maven.plugin.plugin.PluginReport.canGenerateReport()}} currently reads
> {code}
> return "maven-plugin".equals( project.getPackaging() );
> {code}
> I propose to change it to 
> {code}
> return "maven-plugin".equals( project.getPackaging() )
>                 || "takari-maven-plugin".equals( project.getPackaging() );
> {code}
> so that also takari-maven-plugins are supported.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message