maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peter Palaga (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MPLUGIN-331) Check the existence of plugin.xml rather than project packaging in PluginReport.canGenerateReport()
Date Thu, 04 Jan 2018 09:25:00 GMT

    [ https://issues.apache.org/jira/browse/MPLUGIN-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311069#comment-16311069
] 

Peter Palaga commented on MPLUGIN-331:
--------------------------------------

[~hboutemy], I assumed this fix is not going to be available in 3.5.* because it is a new
feature rather than a fix. That's why I used {{@since 3.6}} in https://github.com/apache/maven-plugin-tools/pull/10/commits/4537b92fdb8dec01300ee61a1a97baa2ae5d1a41#diff-a72a02035d1c1407a6e5cc6a911a648dR203
Should I change it to 3.5.1?

> Check the existence of plugin.xml rather than project packaging in PluginReport.canGenerateReport()
> ---------------------------------------------------------------------------------------------------
>
>                 Key: MPLUGIN-331
>                 URL: https://issues.apache.org/jira/browse/MPLUGIN-331
>             Project: Maven Plugin Tools
>          Issue Type: Task
>          Components: Plugin Plugin
>            Reporter: Peter Palaga
>             Fix For: 3.5.1
>
>
> {{org.apache.maven.plugin.plugin.PluginReport.canGenerateReport()}} currently reads
> {code}
> return "maven-plugin".equals( project.getPackaging() );
> {code}
> I propose to change it to 
> {code}
> return "maven-plugin".equals( project.getPackaging() )
>                 || "takari-maven-plugin".equals( project.getPackaging() );
> {code}
> so that also takari-maven-plugins are supported.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message