maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rfscholte commented on a change in pull request #10: [MPLUGIN-331] Let plugin:report support takari-maven-plugin packaging
Date Thu, 01 Jan 1970 00:00:00 GMT
rfscholte commented on a change in pull request #10: [MPLUGIN-331] Let plugin:report support
takari-maven-plugin packaging
URL: https://github.com/apache/maven-plugin-tools/pull/10#discussion_r160055432
 
 

 ##########
 File path: maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/PluginReport.java
 ##########
 @@ -197,9 +197,18 @@
     @Component
     private RuntimeInformation rtInfo;
 
+    /**
+     * Path to {@code plugin.xml} plugin descriptor to generate the report from.
+     *
+     * @since 3.5.1
+     */
+    @Parameter( defaultValue = "${project.build.outputDirectory}/META-INF/maven/plugin.xml",
required = true )
 
 Review comment:
   https://maven.apache.org/ref/3.5.2/maven-plugin-api/ says that the `plugin.xml` is alwys
expected at this location. So it should be considered a contant, not a variable, hence why
I would like to see it as readOnly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message