Mailing-List: contact issues-help@maven.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@maven.apache.org
Date: Mon, 4 Dec 2017 14:57:00 +0000 (UTC)
From: "Andreas Sewe (JIRA)" <jira@apache.org>
To: issues@maven.apache.org
Message-ID: <JIRA.13122562.1512389620000.378762.1512399420258@Atlassian.JIRA>
In-Reply-To: <JIRA.13122562.1512389620000@Atlassian.JIRA>
References: <JIRA.13122562.1512389620000@Atlassian.JIRA> <JIRA.13122562.1512389620983@jira-lw-us.apache.org>
Subject: [jira] [Commented] (MRESOLVER-38) SOE/OOME in
 DefaultDependencyNode.accept
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Mon, 04 Dec 2017 14:57:06 -0000


    [ https://issues.apache.org/jira/browse/MRESOLVER-38?page=3Dcom.atlassi=
an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16=
276894#comment-16276894 ]=20

Andreas Sewe commented on MRESOLVER-38:
---------------------------------------

What=E2=80=99s *worse*: There exist artifacts for which doing a simple {{co=
llectDependencies}} does not result in {{StackOverflowError}} but in an {{O=
utOfMemoryError}}; thus, this can kill not just one but all threads.

Using {{GetDependencyTree}} on {{org.webjars.npm:babel-plugin-transform-cla=
ss-constructor-call:6.3.13}} again produces a huge stack of {{DefaultDepend=
encyNode.accept}}, but with the additional problem that the constructs a hu=
ge (160k entries!) {{paths}} {{List<List<DependencyNode>>}} (counted using =
Eclipse MAT on a heap dump.)

{noformat}
Exception in thread "main" java.lang.OutOfMemoryError: Java heap space
=09at org.eclipse.aether.util.graph.visitor.PathRecordingDependencyVisitor.=
visitEnter(PathRecordingDependencyVisitor.java:108)
=09at org.eclipse.aether.graph.DefaultDependencyNode.accept(DefaultDependen=
cyNode.java:341)
=09at org.eclipse.aether.graph.DefaultDependencyNode.accept(DefaultDependen=
cyNode.java:345)
=09at org.eclipse.aether.graph.DefaultDependencyNode.accept(DefaultDependen=
cyNode.java:345)
=09at org.eclipse.aether.graph.DefaultDependencyNode.accept(DefaultDependen=
cyNode.java:345)
=09at org.eclipse.aether.graph.DefaultDependencyNode.accept(DefaultDependen=
cyNode.java:345)
=E2=80=A6
{noformat}

> SOE/OOME in DefaultDependencyNode.accept
> ----------------------------------------
>
>                 Key: MRESOLVER-38
>                 URL: https://issues.apache.org/jira/browse/MRESOLVER-38
>             Project: Maven Resolver
>          Issue Type: Bug
>          Components: resolver
>    Affects Versions: Maven Artifact Resolver 1.1.0
>            Reporter: Andreas Sewe
>            Priority: Critical
>         Attachments: maven-resolver-demos.patch
>
>
> I noticed a {{StackOverflowErrror}} when trying to build the classpath fo=
r {{org.webjars.npm:n3-charts:2.0.17}} using Maven Resolver 1.1.0.
> I=E2=80=99ve managed to produce a minimal example based on the {{maven-re=
solver-demos}} from the {{master-with-demos}} branch. To reproduce, just ap=
ply the attached patch to the branch (tried this with commit [{{84a32a86}}|=
https://github.com/apache/maven-resolver/commit/84a32a866ff27d4df75124074fd=
925588f4a574d]) and run the {{GetDependencyTree}} example:
> {noformat}
> ------------------------------------------------------------
> GetDependencyTree
> SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
> SLF4J: Defaulting to no-operation (NOP) logger implementation
> SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further=
 details.
> Resolving artifact org.webjars.npm:n3-charts:pom:2.0.17
> Resolved artifact org.webjars.npm:n3-charts:pom:2.0.17 from central (http=
s://repo.maven.apache.org/maven2/, default, releases+snapshots)
> =E2=80=A6
> Resolving metadata org.webjars.npm:uglifycss/maven-metadata.xml from cent=
ral (https://repo.maven.apache.org/maven2/, default, releases+snapshots)
> Resolved metadata org.webjars.npm:uglifycss/maven-metadata.xml from centr=
al (https://repo.maven.apache.org/maven2/, default, releases+snapshots)
> Resolving artifact org.webjars.npm:uglifycss:pom:0.0.18
> Resolved artifact org.webjars.npm:uglifycss:pom:0.0.18 from central (http=
s://repo.maven.apache.org/maven2/, default, releases+snapshots)
> Exception in thread "main" java.lang.StackOverflowError
> =09at org.eclipse.aether.util.graph.visitor.PathRecordingDependencyVisito=
r.visitEnter(PathRecordingDependencyVisitor.java:102)
> =09at org.eclipse.aether.graph.DefaultDependencyNode.accept(DefaultDepend=
encyNode.java:341)
> =09at org.eclipse.aether.graph.DefaultDependencyNode.accept(DefaultDepend=
encyNode.java:345)
> =09at org.eclipse.aether.graph.DefaultDependencyNode.accept(DefaultDepend=
encyNode.java:345)
> =09at org.eclipse.aether.graph.DefaultDependencyNode.accept(DefaultDepend=
encyNode.java:345)
> {noformat}
> (Note: The patch changes the {{plexus-utils}} version as well, as I was g=
etting a {{ClassNotFoundException}} for {{org.codehaus.plexus.util.xml.pull=
.EntityReplacementMap}} otherwise.)


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)