maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Scholte (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MSHADE-265) correct merging of module-info in shades
Date Sun, 05 Nov 2017 10:08:00 GMT

    [ https://issues.apache.org/jira/browse/MSHADE-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239480#comment-16239480
] 

Robert Scholte commented on MSHADE-265:
---------------------------------------

Not sure you are aware of it, but with MSHADE-258 module-info files are already removed. The
idea is that if you don't add a module descriptor, then there's no need to keep these files:
they should end up on the classpath anyway disabling all JPMS features.

> correct merging of module-info in shades
> ----------------------------------------
>
>                 Key: MSHADE-265
>                 URL: https://issues.apache.org/jira/browse/MSHADE-265
>             Project: Maven Shade Plugin
>          Issue Type: Improvement
>            Reporter: Romain Manni-Bucau
>            Priority: Trivial
>
> Should work by merging of the encountered module info jut also automatic module name
in manifest. The hard part being removing the not needed entries which are sometimes not simply
the ones of the included classes - SPI need it still



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message