maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tibo (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MCHECKSTYLE-341) Introduce an expectedViolation flag
Date Fri, 29 Sep 2017 08:42:01 GMT

    [ https://issues.apache.org/jira/browse/MCHECKSTYLE-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16185512#comment-16185512
] 

Tibo commented on MCHECKSTYLE-341:
----------------------------------

Alright no point arguing.
Yes there is better tool to do that. You see a bad sign and you are right, we are in a really
bad position. Put 300 developer on the same codebase with no rules for 10 years and that's
what you end up with. Also we are a bank and any new tool take 6month to be approved and 6
other months to be setup.
Coding in our project is nothing but fun at the moment and our developers are screaming for
more enforcement, it won't feel like punishment, trust me.
I was just thinking that implementing it in checkstyle would be straightforward and useful
for all companies in our situation...


> Introduce an expectedViolation flag
> -----------------------------------
>
>                 Key: MCHECKSTYLE-341
>                 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-341
>             Project: Maven Checkstyle Plugin
>          Issue Type: New Feature
>          Components: checkstyle:check
>    Affects Versions: 2.17
>            Reporter: Tibo
>            Priority: Minor
>
> We are trying to fix our tech debt step by step using the maxAllowedViolation flag and
reducing the number slowly.
> We have 400+ maven module in our project and developer never update this flag, So basically
when someone is fixing checkstyle error without updating the flag, it leaves room for another
developer to introduce new errors...
> I would like an expectedViolation flag just to force people who are fixing issues to
also update the count... It could be called "expectedViolation". The difference with the maxAllowedViolation
flag is that this one would also fail when the number of actual violation is less than the
"expectedViolation" flag.
> I believe the maxAllowedViolation should have been an expectedViolation from the start.
I don't believe anyone wants to leave room for violation, you just want, for an existing project,
to explicitly specify the current number of violation and disallow through pull request the
number to go up.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message