Mailing-List: contact issues-help@maven.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@maven.apache.org
Date: Tue, 15 Aug 2017 19:51:00 +0000 (UTC)
From: "John Vines (JIRA)" <jira@apache.org>
To: issues@maven.apache.org
Message-ID: <JIRA.13093314.1502227905000.36400.1502826660292@Atlassian.JIRA>
In-Reply-To: <JIRA.13093314.1502227905000@Atlassian.JIRA>
References: <JIRA.13093314.1502227905000@Atlassian.JIRA> <JIRA.13093314.1502227905202@jira-lw-us.apache.org>
Subject: [jira] [Comment Edited] (MASSEMBLY-866) poor performance of
 jar-with-dependencies when run in same run as docbook
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 15 Aug 2017 19:51:07 -0000


    [ https://issues.apache.org/jira/browse/MASSEMBLY-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120192#comment-16120192 ] 

John Vines edited comment on MASSEMBLY-866 at 8/15/17 7:50 PM:
---------------------------------------------------------------

-Maven - seen on both 3.3.9 and 3.5.0
JDK - Openjdk 1.7.0.141, oracle 1.7.0_75, oracle 1.7.0_67
Yes, we are doing a maven job in jenkins
Running test with 2.6 now ( will also run test with those overrides, wasn't sure if I could override plugins like that)
228M
Which flags would you like?
-

Ugh, I apologize, I thought I had narrowed it down to my two modules (i.e. docbook + assembly) but turns out I had screwed up something context switching. It is slow, but it is under certain conditions that are not the ones laid out above, as well as those versions above.

I can state for certain I've seen it occuring on
{code}Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T11:41:47-05:00)
Maven home: /usr/share/maven
Java version: 1.7.0_141, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-1.7.0-openjdk-1.7.0.141-2.6.10.1.el7_3.x86_64/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "3.10.0-514.16.1.el7.x86_64", arch: "amd64", family: "unix"
{code} and {code}Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426; 2017-04-03T15:39:06-04:00)
Maven home: /usr/local/Cellar/maven/3.5.0/libexec
Java version: 1.7.0_67, vendor: Oracle Corporation
Java home: /Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.12.3", arch: "x86_64", family: "mac"
{code}

I'm slowly going through iterations so I don't screw up my analysis again


was (Author: vines):
Maven - seen on both 3.3.9 and 3.5.0
JDK - Openjdk 1.7.0.141, oracle 1.7.0_75, oracle 1.7.0_67
Yes, we are doing a maven job in jenkins
Running test with 2.6 now ( will also run test with those overrides, wasn't sure if I could override plugins like that)
228M
Which flags would you like?


> poor performance of jar-with-dependencies when run in same run as docbook
> -------------------------------------------------------------------------
>
>                 Key: MASSEMBLY-866
>                 URL: https://issues.apache.org/jira/browse/MASSEMBLY-866
>             Project: Maven Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: John Vines
>              Labels: performance
>
> I apologize for the lack of information, but we have a large build environment which I cannot share, but I'll try to explain things as best I can.
> In our full build path, we have 2 components that I've found have side effects. One is a doc build which uses the docbkx-maven-plugin (https://github.com/mimil/docbkx-tools) to generate documentation (and usually takes a while, ~27 minutes) and another which builds a jar-with-depends for our UI. Prior to upgrade the assembly plugin to 3.0.0 from 2.3 or 2.5 (I cannot recall) everything ran fine. After upgrading we found our jenkins builds taking about 40 more minutes, most of this change was in maven-assembly-plugin for that UI jar-with-dependencies
> {code}assembly-plugin:3.0.0:single (make-assembly) @ sqrrl-web-dist-ui ---
> 16:17:37 [INFO] Reading assembly descriptor: src/main/assembly/dist-ui.xml
> 16:17:40 [INFO] Building jar: /var/lib/jenkins/workspace/sqrrl-master-build/web/dist-ui/target/sqrrl-web-dist-ui-2.8.0-SNAPSHOT-jar-with-dependencies.jar
> 17:01:54 [INFO] {code}
> Eventually I isolated to a case where just that doc and that jar-with-deps being built would cause the jar-with-deps to take ~40 minutes, but if I built it by itself (all other maven options being equal) it would take about 1.5 minutes.
> I'm honestly not too familiar with the inner workings of this plugin, nor the maven docbook plugin, but my hunch was that the docbook plugin was 'corrupting' or otherwise altering the main maven jvm in such a way to cause this. It does use some really old plexus plugins, among others, afterall. However, I stumbled across MASSEMBLY-424 and tested forking maven-assembly-plugin:3.0.0 and updating plexus-archiver to 3.5, plexus-io to 3.0.0 and plexus-utils to 3.1.0 and ran my 2 module build with the custom plugin and it ran just as quick as being run standalone (1.5minutes). (To build it with those plugins I had to disable checkstyle and enforcer though since at least one of those plugins versions was java7)
> One last datapoint is that in our jar-with-deps we are including bouncycastle's bcpix and bcprov and explicitly excluding them from the jar-with-depends also made that 2 module build faster (but not as fast), so I'm not 100% sure it's the docbook plugin was the catalyst there.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)