maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andreas Schaller (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SCM-777) Maven plugin's scm:validate ignores scmCheckWorkingDirectoryUrl configuration in favor of system property
Date Tue, 15 Aug 2017 09:13:00 GMT

    [ https://issues.apache.org/jira/browse/SCM-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16126979#comment-16126979
] 

Andreas Schaller commented on SCM-777:
--------------------------------------

In ValidateMojo, the field that gets the configuration value injected is described as unused:
{code:java}
    @Parameter( property = "scmCheckWorkingDirectoryUrl", defaultValue = "false" )
    // Actually unused in the code here. Present for doc purpose,
    // see org.apache.maven.scm.provider.svn.AbstractSvnScmProvider.CHECK_WORKING_DIRECTORY_URL
    private boolean scmCheckWorkingDirectoryUrl;
{code}

In the validateConnection-method however, the field is used to store the current working directory
as system property.
Wouldn't it be sufficient to also store the value of scmCheckWorkingDirectoryUrl as system
propety at this point so that it can be used in AbstractSvnScmProvider?
Not nice but should work

> Maven plugin's scm:validate ignores scmCheckWorkingDirectoryUrl configuration in favor
of system property
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: SCM-777
>                 URL: https://issues.apache.org/jira/browse/SCM-777
>             Project: Maven SCM
>          Issue Type: Bug
>          Components: maven-plugin
>    Affects Versions: 1.9.1
>         Environment: Java 7 x64 on Windows 7
>            Reporter: Mark Herman
>
> org.apache.maven.scm.manager.AbstractScmManager.checkWorkingDirectoryUrl() uses... {code}
Boolean.getBoolean( CHECK_WORKING_DIRECTORY_URL ) {code}  ...in order to check if it should
check the repository on scm:validate.  This will only react to the system property, and not
to the maven configuration.
> *Result:* no maven config will enable the check working directory option, only passing
it in as a jvm argument.
> *Expected:* this should work:
> {code}
> <plugin>
>     <groupId>org.apache.maven.plugins</groupId>
>     <artifactId>maven-scm-plugin</artifactId>
>     <configuration>
>         <scmCheckWorkingDirectoryUrl>true</scmCheckWorkingDirectoryUrl> 
<!-- this configuration is ignored, don't know why -->
>     </configuration>
>     <executions>
>         <execution>
>           <phase>validate</phase>
>           <configuration>
>             <scmCheckWorkingDirectoryUrl>true</scmCheckWorkingDirectoryUrl>
<!-- neither does this -->
>           </configuration>
>           <goals>
>             <goal>validate</goal>
>           </goals>
>         </execution>
>     </executions>
> </plugin>
> {code}
> *Workaround:* Use <systemProperty> section.  Tried <systemPropertyVariables>
and for some reason that didn't appear to work.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message