maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (SUREFIRE-1396) Provider class path is incorrect for custom provider in Failsafe
Date Mon, 31 Jul 2017 21:02:01 GMT


ASF GitHub Bot commented on SUREFIRE-1396:

Github user jon-bell commented on the issue:
    Thanks - I made the fixes you suggested above, and confirmed that the build passed on
`mvn clean install -P run-its`

> Provider class path is incorrect for custom provider in Failsafe
> ----------------------------------------------------------------
>                 Key: SUREFIRE-1396
>                 URL:
>             Project: Maven Surefire
>          Issue Type: Bug
>            Reporter: Jonathan Bell
> Hi,
> When using a custom Surefire provider with Surefire (not Failsafe), the "provider classpath"
contains only the provider and surefire-api. However, when using a custom provider with Failsafe,
the provider class path ends up including a lot more... it seems like perhaps all plugins
that are loaded? This has caused some mayhem for me when using a custom provider in projects
that use a specific version of SLF4J... because then failsafe forces 1.5.6 to be loaded (from
this process of incorrectly finding the custom provider), causing a crash.
> It is a simple fix (3 lines in AbstractSurefireMojo - it had the name of the Surefire
plugin hardcoded, which isn't correct when it's actually Failsafe). I've got a patched fork
of master on GitHub (
that fixes it and an integration test that demonstrates the flaw. I am not 100% sure on the
formatting of the integration test (i.e., I am opening a JIRA ticket so that I suppose I can
name it under the JIRA issue? How should I specify the current version of surefire in the
integration test package?) - if the fix is welcome against master I'd be happy to open a PR
on GitHub. I am also happy to merge against a different branch if it's more helpful.

This message was sent by Atlassian JIRA

View raw message