maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MENFORCER-276) Allow ignoring dependency scopes in RequireUpperBoundDeps
Date Tue, 04 Jul 2017 13:15:00 GMT

    [ https://issues.apache.org/jira/browse/MENFORCER-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073651#comment-16073651
] 

ASF GitHub Bot commented on MENFORCER-276:
------------------------------------------

GitHub user oleg-nenashev opened a pull request:

    https://github.com/apache/maven-enforcer/pull/25

    [MENFORCER-276]

    We have recently adopted `RequireUpperBoundDeps` in the Jenkins project (https://github.com/jenkinsci/plugin-pom/pull/67).
In order to implement it, Jesse Glick added a support of ignoring particular dependencies
in [MENFORCER-273](https://issues.apache.org/jira/browse/MENFORCER-273).
    
    Sometimes we declare dependencies between plugins for testing purposes (scope=test), and
in such case RequireUpperBoundDeps fails the build if there is a test dependency conflicting
with the main code. Although it may cause instability of tests (including false positive results),
it does not really impact the distributable package in our case.
    
    I propose to add another option for filtering of dependency scopes. This pull request
also adds some unit tests for `RequireUpperBoundDeps`. Previously it had integration tests
only.
    
    https://issues.apache.org/jira/browse/MENFORCER-276
    
    @reviewbybees @jglick @stephenc 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/oleg-nenashev/maven-enforcer MENFORCER-276

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven-enforcer/pull/25.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #25
    
----
commit 7a59dcf9997e76b153ff84889cb904042fa094ae
Author: Oleg Nenashev <o.v.nenashev@gmail.com>
Date:   2017-07-04T13:10:39Z

    Add Unit tests for RequireUpperBoundDeps

commit 0ba4ab6cef127a1e347fbcbe6b46d4a6ec150ce4
Author: Oleg Nenashev <o.v.nenashev@gmail.com>
Date:   2017-07-04T13:12:39Z

    [MENFORCER-276] - Add the ignoreDependencyScopes option to RequireUpperBoundDeps

----


> Allow ignoring dependency scopes in RequireUpperBoundDeps
> ---------------------------------------------------------
>
>                 Key: MENFORCER-276
>                 URL: https://issues.apache.org/jira/browse/MENFORCER-276
>             Project: Maven Enforcer Plugin
>          Issue Type: New Feature
>            Reporter: Oleg Nenashev
>
> We have recently adopted RequireUpperBoundDeps in the Jenkins project (https://github.com/jenkinsci/plugin-pom/pull/67).
In order to implement it, [~jglick@netbeans.org] added a support of ignoring particular dependencies
in MENFORCER-273.
> Sometimes we declare dependencies between plugins for testing purposes (scope=test),
and in such case RequireUpperBoundDeps fails the build if there is a test dependency conflicting
with the main code. Although it may cause instability of tests (including false positive results),
it does not really impact the distributable package in our case.
> I propose to add another option for filtering of dependency scopes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message