Mailing-List: contact issues-help@maven.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@maven.apache.org
Date: Sun, 25 Jun 2017 11:50:00 +0000 (UTC)
From: "Ed Randall (JIRA)" <jira@apache.org>
To: issues@maven.apache.org
Message-ID: <JIRA.12800050.1424244976000.100160.1498391400267@Atlassian.JIRA>
In-Reply-To: <JIRA.12800050.1424244976000@Atlassian.JIRA>
References: <JIRA.12800050.1424244976000@Atlassian.JIRA> <JIRA.12800050.1424244976228@jira-lw-us.apache.org>
Subject: [jira] [Comment Edited] (MCHECKSTYLE-287) checkstyle report throws
 NPE
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sun, 25 Jun 2017 11:50:06 -0000


    [ https://issues.apache.org/jira/browse/MCHECKSTYLE-287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062292#comment-16062292 ] 

Ed Randall edited comment on MCHECKSTYLE-287 at 6/25/17 11:49 AM:
------------------------------------------------------------------

Am trying to follow the documentation for multimodule configuration, should be supported: https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/multi-module-config.html
OK I got it - the csrules sub-module can be there but must explicitly *not* share the project parent pom, the reactor then builds correctly.
The demo project then illustrates the issue on a clean cache, will re-upload....


was (Author: edrandall):
Am trying to follow the documentation for multimodule configuration, should be supported: https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/multi-module-config.html

> checkstyle report throws NPE
> ----------------------------
>
>                 Key: MCHECKSTYLE-287
>                 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-287
>             Project: Maven Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.13, 2.14
>            Reporter: Thomas Scheffler
>         Attachments: patch1.diff, projects.tar.gz
>
>
> I don't know what triggers this bug. Somehow org.apache.maven.plugin.checkstyle.AbstractCheckstyleReport.collectArtifacts(String) produces a List which contains the null object. And therefor an exception is thrown here (2.14):
> {noformat}
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.3:site (default-site) on project oaipmh: Execution default-site of goal org.apache.maven.plugins:maven-site-plugin:3.3:site failed. NullPointerException -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.3:site (default-site) on project oaipmh: Execution default-site of goal org.apache.maven.plugins:maven-site-plugin:3.3:site failed.
> 	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:224)
> 	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> 	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> 	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
> 	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
> 	at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
> 	at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120)
> 	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:355)
> 	at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155)
> 	at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
> 	at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:216)
> 	at org.apache.maven.cli.MavenCli.main(MavenCli.java:160)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:606)
> 	at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> 	at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> 	at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> 	at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution default-site of goal org.apache.maven.plugins:maven-site-plugin:3.3:site failed.
> 	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:143)
> 	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
> 	... 19 more
> Caused by: java.lang.NullPointerException
> 	at org.apache.maven.plugin.checkstyle.exec.DefaultCheckstyleExecutor.configureResourceLocator(DefaultCheckstyleExecutor.java:852)
> 	at org.apache.maven.plugin.checkstyle.exec.DefaultCheckstyleExecutor.executeCheckstyle(DefaultCheckstyleExecutor.java:102)
> 	at org.apache.maven.plugin.checkstyle.AbstractCheckstyleReport.executeReport(AbstractCheckstyleReport.java:474)
> 	at org.apache.maven.plugin.checkstyle.CheckstyleReport.executeReport(CheckstyleReport.java:156)
> 	at org.apache.maven.reporting.AbstractMavenReport.generate(AbstractMavenReport.java:255)
> 	at org.apache.maven.plugins.site.ReportDocumentRenderer.renderDocument(ReportDocumentRenderer.java:219)
> 	at org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.renderModule(DefaultSiteRenderer.java:319)
> 	at org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render(DefaultSiteRenderer.java:135)
> 	at org.apache.maven.plugins.site.SiteMojo.renderLocale(SiteMojo.java:175)
> 	at org.apache.maven.plugins.site.SiteMojo.execute(SiteMojo.java:138)
> 	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132)
> 	... 20 more
> {noformat}
> Looking at the code, you see a null check is done for the list, bit not for elements of that list:
> {noformat}
>         // MCHECKSTYLE-225: load licenses from additional artifacts, not from classpath
>         if ( additionalArtifacts != null )
>         {
>             for ( Artifact licenseArtifact : additionalArtifacts )
>             {
>                 try
>                 {
>                     resourceManager.addSearchPath( "jar", "jar:" + licenseArtifact.getFile().toURI().toURL() );
>                 }
>                 catch ( MalformedURLException e )
>                 {
>                     // noop
>                 }
>             }
>         }
> {noformat}


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)