maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SUREFIRE-1384) Add ProviderInfo for JUnit Plattform to enable automatic provider lookup
Date Sat, 10 Jun 2017 12:19:19 GMT

    [ https://issues.apache.org/jira/browse/SUREFIRE-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045505#comment-16045505
] 

ASF GitHub Bot commented on SUREFIRE-1384:
------------------------------------------

Github user Tibor17 commented on a diff in the pull request:

    https://github.com/apache/maven-surefire/pull/153#discussion_r121256322
  
    --- Diff: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
---
    @@ -1399,12 +1400,22 @@ private static void checkThreadCountEntity( int count, String
entity )
     
         private boolean isJunit47Compatible( Artifact artifact )
         {
    -        return dependencyResolver.isWithinVersionSpec( artifact, "[4.7,)" );
    +        return dependencyResolver.isWithinVersionSpec( artifact, "[4.7,4.12.0)" );
         }
     
         private boolean isAnyJunit4( Artifact artifact )
         {
    -        return dependencyResolver.isWithinVersionSpec( artifact, "[4.0,)" );
    +        return dependencyResolver.isWithinVersionSpec( artifact, "[4.0,4.12.0)" );
    --- End diff --
    
    Same here.


> Add ProviderInfo for JUnit Plattform to enable automatic provider lookup
> ------------------------------------------------------------------------
>
>                 Key: SUREFIRE-1384
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1384
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: JUnit 5.x support
>            Reporter: Benedikt Ritter
>             Fix For: 3.0-RC1
>
>
> In order to enable automatic provider lookup for JUnit Plattform/JUnit 5, we need to
add the corresponding ProviderInfo implementation to AbstractSurefireMojo.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message