maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Osipov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MNG-6209) inconsistent activation of components from multiple extensions=true plugins
Date Mon, 05 Jun 2017 15:21:04 GMT

    [ https://issues.apache.org/jira/browse/MNG-6209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16037088#comment-16037088
] 

Michael Osipov commented on MNG-6209:
-------------------------------------

I am not certain. The code remained the same for more than seven years now. The descriptor
can also be located in another JARs, but always on the plugin classpath.

I did apply now this patch locally:

{noformat}
Index: src/main/java/org/apache/maven/plugins/assembly/io/DefaultAssemblyReader.java
===================================================================
--- src/main/java/org/apache/maven/plugins/assembly/io/DefaultAssemblyReader.java       (revision
1797662)
+++ src/main/java/org/apache/maven/plugins/assembly/io/DefaultAssemblyReader.java       (working
copy)
@@ -196,7 +196,7 @@
                                                             InvalidAssemblerConfigurationException
     {
         final InputStream resourceAsStream =
-            Thread.currentThread().getContextClassLoader().getResourceAsStream( "assemblies/"
+ ref + ".xml" );
+            getClass().getClassLoader().getResourceAsStream( "assemblies/" + ref + ".xml"
);

         if ( resourceAsStream == null )
         {
{noformat} 

and it does work. So Igor, you idea was correct. [~hboutemy], [~igorf], what bothers me now
is that decriptor ref usecases with 3.5.1 will be broken when shipped even if I address this
issue in MASSEMBLY. Any thoughts?

> inconsistent activation of components from multiple extensions=true plugins
> ---------------------------------------------------------------------------
>
>                 Key: MNG-6209
>                 URL: https://issues.apache.org/jira/browse/MNG-6209
>             Project: Maven
>          Issue Type: Bug
>          Components: Class Loading
>    Affects Versions: 3.3.1, 3.3.3, 3.3.9
>            Reporter: Igor Fedorenko
>            Assignee: Igor Fedorenko
>             Fix For: 3.5.1
>
>
> This is a regression introduced by the fix for MNG-5742. When multiple extensions=true
plugins configured in the build, when mojos from one such plugin are executed, components
from other extensions are ignored.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message