maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Osipov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MWAR-407) Binary files are modified during web.xml filtering
Date Mon, 22 May 2017 21:06:04 GMT

    [ https://issues.apache.org/jira/browse/MWAR-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020205#comment-16020205
] 

Michael Osipov commented on MWAR-407:
-------------------------------------

This is a regression caused by MWAR-404. [This|https://svn.apache.org/viewvc/maven/plugins/trunk/maven-war-plugin/src/main/java/org/apache/maven/plugins/war/packaging/WarProjectPackagingTask.java?r1=1792380&r2=1792379&pathrev=1792380]
diff needs to be reverted.
The commit blindly assumes that filterDescriptors can be blindly passed to {{#copyFiles()}}.
That's wrong. It will filter ALL files. The entire {{containerConfigXML}}} parameter is wrong
and here is the issue for MWAR-307.

[~khmarbaise], please revert MWAR-404. The current code won't work for anything but Tomcat's
{{container.xml}}. We need a general approach as described in MWAR-307.

> Binary files are modified during web.xml filtering
> --------------------------------------------------
>
>                 Key: MWAR-407
>                 URL: https://issues.apache.org/jira/browse/MWAR-407
>             Project: Maven WAR Plugin
>          Issue Type: Bug
>          Components: filtering
>    Affects Versions: 3.1.0
>            Reporter: Maxim Solodovnik
>
> Binary files are being modified in case
> {code}
> <filteringDeploymentDescriptors>true</filteringDeploymentDescriptors>
> {code}
> option is used
> here is the quick-start project https://github.com/solomax/filter-war/
> UPDATE: works as expected with maven-war-plugin 3.0.0



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message