Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 304F7200C52 for ; Mon, 10 Apr 2017 18:30:46 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 2EC89160BA5; Mon, 10 Apr 2017 16:30:46 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 73DD8160B7F for ; Mon, 10 Apr 2017 18:30:45 +0200 (CEST) Received: (qmail 24168 invoked by uid 500); 10 Apr 2017 16:30:44 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 24157 invoked by uid 99); 10 Apr 2017 16:30:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Apr 2017 16:30:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 4592BCD376 for ; Mon, 10 Apr 2017 16:30:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id m3KLyEZww7PC for ; Mon, 10 Apr 2017 16:30:43 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 236F25F1E9 for ; Mon, 10 Apr 2017 16:30:43 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6E2D1E04AB for ; Mon, 10 Apr 2017 16:30:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id E504D24066 for ; Mon, 10 Apr 2017 16:30:41 +0000 (UTC) Date: Mon, 10 Apr 2017 16:30:41 +0000 (UTC) From: "Mikhail Stepura (JIRA)" To: issues@maven.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SUREFIRE-1314) rerunFailingTestsCount doesn't work for errors in BeforeClass methods MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 10 Apr 2017 16:30:46 -0000 [ https://issues.apache.org/jira/browse/SUREFIRE-1314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963116#comment-15963116 ] Mikhail Stepura commented on SUREFIRE-1314: ------------------------------------------- I don't see why that's a JUnit problem. {{rerunFailingTestsCount}} is a functionality wich is specific to surefire, and JUnit has no idea about that. The current implementation of {{JUnit4ProviderUtil#generateFailingTests(java.util.List)}} filters out those failures with {{description.isTest() == false}}. Which is the case both for a suite failure and a {{BeforeClass}} failure. Also {{JUnit4ProviderUtil#cutTestClassAndMethod}} doesn't work with those descriptions, as they don't contain a method name. > rerunFailingTestsCount doesn't work for errors in BeforeClass methods > --------------------------------------------------------------------- > > Key: SUREFIRE-1314 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1314 > Project: Maven Surefire > Issue Type: Bug > Components: Junit 4.x support > Affects Versions: 2.19.1 > Reporter: Mikhail Stepura > > We're using {{surefire.rerunFailingTestsCoun}} property for our integration tests, and everything working fine when an error/failure happens in a test method (i.e. {{@Test}} ), and those test methods are re-executed later, as expected. > But if an error happens in a {{BeforeClass}} class method, then those test classes are not re-executed. -- This message was sent by Atlassian JIRA (v6.3.15#6346)