maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tibor Digana (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SUREFIRE-1314) rerunFailingTestsCount doesn't work for errors in BeforeClass methods
Date Mon, 10 Apr 2017 21:05:41 GMT

    [ https://issues.apache.org/jira/browse/SUREFIRE-1314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963484#comment-15963484
] 

Tibor Digana commented on SUREFIRE-1314:
----------------------------------------

[~mishail]
After having a look in Surefire code, now I will explain why I think it is JUnit issue and
you should report a bug in GitHub.
The failures come from {{RunListener#testFailure( Failure failure )}}.
The description {{test(jiras.surefire1146.ErrorInBeforeClassTest)}} looks like a test method,
and the method {{isTest}} should return true.
Surefire must not make any guesses about description and must fully trust JUnit.
Therefore you should report bug against JUnit. I think this callback method should not be
called by JUnit at all.
I know junit committers, so you can link both tickets and I can participate there. If junit
comitters give me a valuable workaround we can continue. I will temporarily close this issue.

> rerunFailingTestsCount doesn't work for errors in BeforeClass methods
> ---------------------------------------------------------------------
>
>                 Key: SUREFIRE-1314
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1314
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: Junit 4.x support
>    Affects Versions: 2.19.1
>            Reporter: Mikhail Stepura
>            Assignee: Tibor Digana
>
> We're using {{surefire.rerunFailingTestsCoun}} property for our integration tests, and
everything working fine when an error/failure happens in a test method (i.e. {{@Test}} ),
and those test methods are re-executed later, as expected.
> But if an error happens in a {{BeforeClass}} class method, then those test classes are
not re-executed. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message