Mailing-List: contact issues-help@maven.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@maven.apache.org
Date: Tue, 28 Feb 2017 04:54:45 +0000 (UTC)
From: "Daniel Halperin (JIRA)" <jira@apache.org>
To: issues@maven.apache.org
Message-ID: <JIRA.13046323.1488060735000.14407.1488257685395@Atlassian.JIRA>
In-Reply-To: <JIRA.13046323.1488060735000@Atlassian.JIRA>
References: <JIRA.13046323.1488060735000@Atlassian.JIRA> <JIRA.13046323.1488060735568@jira-lw-us.apache.org>
Subject: [jira] [Commented] (MSHADE-252) shadeSourcesContent is broken when
 combined with partial relocation
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 28 Feb 2017 04:54:51 -0000


    [ https://issues.apache.org/jira/browse/MSHADE-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15887257#comment-15887257 ] 

Daniel Halperin commented on MSHADE-252:
----------------------------------------

I was about to file a related issue -- I think this might happen even for regular (non-sources) contents:

See a full repro: https://github.com/dhalperi/shading-demo

> shadeSourcesContent is broken when combined with partial relocation
> -------------------------------------------------------------------
>
>                 Key: MSHADE-252
>                 URL: https://issues.apache.org/jira/browse/MSHADE-252
>             Project: Maven Shade Plugin
>          Issue Type: Bug
>    Affects Versions: 2.4.3, 3.0.0
>            Reporter: Zhenyu Yang
>              Labels: easyfix
>
> per description in https://maven.apache.org/plugins/maven-shade-plugin/shade-mojo.html#shadeSourcesContent, when set it to true, 
> "it will attempt to shade the contents of the java source files when creating the sources jar." However, it seems will blindly shade all the source files include those are excluded from relocation rules.
> This could be illustrated with a simple example:
> Assume there are two classes defined in two packages as below:
> A.java:
> package com.fake.fooA;
> import com.fake.fooB;
> public Class A {}
> B.java:
> package com.fake.fooB;
> import com.fake.fooA;
> public class B {}
> and the maven config looks like:
>      <plugin>
>         <groupId>org.apache.maven.plugins</groupId>
>         <artifactId>maven-shade-plugin</artifactId>
>         <version>2.4.3</version>
>         <executions>
>           <!-- Run shade goal on package phase -->
>           <execution>
>             <phase>package</phase>
>             <goals>
>               <goal>shade</goal>
>             </goals>
>             <configuration>
>               <shadedArtifactAttached>false</shadedArtifactAttached>
>               <createSourcesJar>true</createSourcesJar>
>               <shadeSourcesContent>true</shadeSourcesContent>
>               <relocations>
>                 <relocation>
>                   <pattern>com.fake</pattern>
>                   <shadedPattern>.com.fake.shaded</shadedPattern>
>                   <excludes>
>                     <exclude>com.fake.fooA.*</exclude>
>                   </excludes>
>                 </relocation>
>                </relocations> 
> Then the shade plugin will modify the B's source file to be:
> package com.fake.shaded.fooB;
> import com.fake.shaded.fooA;
> public class B {}
> Notice that package A's path was also updated, which is wrong as it's not got relocated.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)