maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karl Heinz Marbaise (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (MSHARED-627) Enhance the ArtifactResolver with a method to resolve versions of an Artifact
Date Sun, 26 Feb 2017 19:09:46 GMT

    [ https://issues.apache.org/jira/browse/MSHARED-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15884865#comment-15884865
] 

Karl Heinz Marbaise edited comment on MSHARED-627 at 2/26/17 7:09 PM:
----------------------------------------------------------------------

GAVCT: GroupId/ArtifactId/Version ? What does *C* and *T* Mean? *C* like Coordinates ? 

Hm...maybe I misunderstand a thing, but requesting the Artifact in the different versions
isn't ok from your point of view? Cause I thought an Artifact could exist in difference versions?
So it would make sense to solve those different versions...But this means an Artifact is only
a single Artifact (identified by GAV?) correct?

But If I take a deeper look into the use case I have your notes making more sense. So this
means to enhance the DependencyResolver instead of ArtifactResolver:

{code:java}
public interface DependencyResolver {...
    List<String> resolveDependencyVersions(ProjectBuildingRequest pbr, Dependency mavenDependency);
...
}
{code}
If you are ok with such a solution? (WDYT)?

-But this brings me back to the question if it is a good idea to return just a plain list
of versions as a String..?-

The information given back are metadata yes..Sorry missed your second comment. But wouldn't
that mean we need to introduce some kind of Metadata class? 



was (Author: khmarbaise):
GAVCT: GroupId/ArtifactId/Version ? What does *C* and *T* Mean? *C* like Coordinates ? 

Hm...maybe I misunderstand a thing, but requesting the Artifact in the different versions
isn't ok from your point of view? Cause I thought an Artifact could exist in difference versions?
So it would make sense to solve those different versions...But this means an Artifact is only
a single Artifact (identified by GAV?) correct?

But If I take a deeper look into the use case I have your notes making more sense. So this
means to enhance the DependencyResolver instead of ArtifactResolver:

{code:java}
public interface DependencyResolver {...
    List<String> resolveDependencyVersions(ProjectBuildingRequest pbr, Dependency mavenDependency);
...
}
{code}
If you are ok with such a solution? (WDYT)?

-But this brings me back to the question if it is a good idea to return just a plain list
of versions as a String..?-

The information given back are metadata yes..Sorry missed your second comment.


> Enhance the ArtifactResolver with a method to resolve versions of an Artifact
> -----------------------------------------------------------------------------
>
>                 Key: MSHARED-627
>                 URL: https://issues.apache.org/jira/browse/MSHARED-627
>             Project: Maven Shared Components
>          Issue Type: Improvement
>          Components: maven-artifact-transfer
>    Affects Versions: maven-artifact-transfer-0.9.0
>            Reporter: Karl Heinz Marbaise
>            Assignee: Karl Heinz Marbaise
>            Priority: Minor
>             Fix For: maven-artifact-transfer-1.0.0
>
>
> The maven-artifact-transfer should be enhanced having a method to resolve versions of
artifacts like this:
> {code:java}
> public interface ArtifactResolver {
> ..
> List<String> resolveArtifactVersions( ProjectBuildingRequest buildingRequest, Artifact
mavenArtifact )
>         throws ArtifactResolverException;
> ..
> }
> {code}
> I have a [working implementation|https://svn.apache.org/r1784464] but I'm not sure if
it should return a list of versions as plain String  ?
> This will help to use maven-artifact-transfer also in other plugin for example in versions-maven-plugin.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message