maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Springer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MSHADE-248) shading fails with "error in opening zip file" if createSourcesJar=true and an invalid sources jar file is encountered
Date Wed, 08 Feb 2017 17:23:41 GMT

    [ https://issues.apache.org/jira/browse/MSHADE-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858270#comment-15858270
] 

Ian Springer commented on MSHADE-248:
-------------------------------------

Here is the content of bsh-2.0b4-sources.jar:

{code}
<!DOCTYPE html>
<html>
    <head>
        <meta charset="utf-8">
        <style type="text/css">
            html, body, #partner, iframe {
                height:100%;
                width:100%;
                margin:0;
                padding:0;
                border:0;
                outline:0;
                font-size:100%;
                vertical-align:baseline;
                background:transparent;
            }
            body {
                overflow:hidden;
            }
        </style>
        <meta content="NOW" name="expires">
        <meta content="index, follow, all" name="GOOGLEBOT">
        <meta content="index, follow, all" name="robots">
        <!-- Following Meta-Tag fixes scaling-issues on mobile devices -->
        <meta content="width=device-width; initial-scale=1.0; maximum-scale=1.0; user-scalable=0;"
name="viewport">
    </head>
    <body>
        <div id="partner"></div>
        <script type="text/javascript">
            document.write(
                    '<script type="text/javascript" language="JavaScript"'
                            + 'src="//sedoparking.com/frmpark/'
                            + window.location.host + '/'
                            + 'tierraexpired'
                            + '/park.js">'
                    + '<\/script>'
            );
        </script>
    </body>
</html>
{code}

I have seen this issue in the past with invalid or missing Maven artifacts getting erroneously
saved to local repos (or Nexus) as HTML files.


> shading fails with "error in opening zip file" if createSourcesJar=true and an invalid
sources jar file is encountered
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: MSHADE-248
>                 URL: https://issues.apache.org/jira/browse/MSHADE-248
>             Project: Maven Shade Plugin
>          Issue Type: Bug
>    Affects Versions: 2.4.3
>            Reporter: Ian Springer
>
> {code}
> Downloading: https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> [WARNING] Checksum validation failed, expected <!DOCTYPE but is b95d8d7d1a57cf46d9f0e924f8864f94159bffd3
for https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> Could not validate integrity of download from https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar:
Checksum validation failed, expected <!DOCTYPE but is b95d8d7d1a57cf46d9f0e924f8864f94159bffd3
> [WARNING] Checksum validation failed, expected <!DOCTYPE but is b95d8d7d1a57cf46d9f0e924f8864f94159bffd3
for https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> Downloaded: https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
(2 KB at 1.3 KB/sec)
> {code}
> And then:
> {code}
> ------------------------------------------------------------------------
> BUILD FAILURE
> ------------------------------------------------------------------------
> Total time: 18.486 s
> Finished at: 2017-02-07T11:13:11-05:00
> Final Memory: 72M/977M
> ------------------------------------------------------------------------
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-shade-plugin:2.4.3:shade
(shade) on project jclouds-shaded: Error creating shaded jar: error in opening zip file /Users/ips/.m2/repository/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
-> [Help 1]
> {code}
> bsh is a transitive dep of one of the jars I am shading. Since I can't control the fact
that they have an invalid sources jar published, the shade plugin should be more forgiving
and just log a warning and skip the bsh sources jar when building the shaded sources jar.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message