maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SUREFIRE-1330) JUnit 5 surefire-provider code donation
Date Mon, 06 Feb 2017 19:05:41 GMT

    [ https://issues.apache.org/jira/browse/SUREFIRE-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854556#comment-15854556
] 

ASF GitHub Bot commented on SUREFIRE-1330:
------------------------------------------

GitHub user britter opened a pull request:

    https://github.com/apache/maven-surefire/pull/142

    SUREFIRE-1330: Import provider code donated by JUnit team

    This PR adds the code donated in [SUREFIRE-1330](https://issues.apache.org/jira/browse/SUREFIRE-1330)
by @marcphilipp. Here are the changes I've made after the initial import:
    
    - Removed license file, since we ship the Apache License with our source distribution
    - ASF license header
    - tabs -> spaces
    - Maven code style
    - some clean up
    
    Note that the unit tests in the provider module are not executed since that would require
automatic lookup code for the provider itself. It may be possible to the the tests running
by explicitly declaring the already released provider by the JUnit team as described in their
[documentation](http://junit.org/junit5/docs/current/user-guide/#running-tests-build-maven).
I gave that a try but was unable to get it working.
    
    We currently have no attribution for the JUnit developers or the contributors who wrote
the code. We could add this to the developers section of pom.xml of the provider. @marcphilipp
please let us know who we should attribute this donation to.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/britter/maven-surefire SUREFIRE-1330

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven-surefire/pull/142.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #142
    
----
commit 73e09a8b2b245e76e072c1809e7fa50be02e95b6
Author: Benedikt Ritter <britter@apache.org>
Date:   2017-02-06T13:02:48Z

    SUREFIRE-1330: Import code from https://issues.apache.org/jira/browse/SUREFIRE-1330 unchanged
as provided

commit 0c329812e71f149bb7c92bfaa3fa37c6d2ec6eec
Author: Benedikt Ritter <britter@apache.org>
Date:   2017-02-06T13:20:54Z

    Remove LICENSE file, ALv2 will be part of the source distribution

commit a0d0325db046f266abc401abe3e0047f6ce908c3
Author: Benedikt Ritter <britter@apache.org>
Date:   2017-02-06T13:23:03Z

    Convert spaces to tabs

commit 62d00dca5709c0a089a65f810c1c66c2897b5003
Author: Benedikt Ritter <britter@apache.org>
Date:   2017-02-06T13:25:01Z

    Use Apache Software Foundation License header

commit 9283dee30decf62e12edd5eaea08abd811ee811f
Author: Benedikt Ritter <britter@apache.org>
Date:   2017-02-06T14:20:30Z

    Adopt Apache Maven code style

commit caceca16772c6d11302c2d8627c7f5b7d913878a
Author: Benedikt Ritter <britter@apache.org>
Date:   2017-02-06T17:55:49Z

    Add surefire-junit5 provider as module to the surefire build

commit 43fb41e8d4115830fbeb6d29f1f17efe8e04de5f
Author: Benedikt Ritter <britter@apache.org>
Date:   2017-02-06T17:56:20Z

    Remove unused filed

commit 30ee7b94c3421411aa6257e78f77fe8b88aa125e
Author: Benedikt Ritter <britter@apache.org>
Date:   2017-02-06T18:06:23Z

    Remove usage of internal JUnit API

commit c197b926a5f02ab2a3842d4a8a736315c3c8eb33
Author: Benedikt Ritter <britter@apache.org>
Date:   2017-02-06T18:14:53Z

    Move provider classes to maven surefire package

commit 97f97167ea0aa07bba4bd864b1f686c2f79ca33d
Author: Benedikt Ritter <britter@apache.org>
Date:   2017-02-06T18:17:36Z

    Remove engine declaration - this should be done automatically by surefire

commit b08b1aeae4ad01582fd6264462a4a9345bfd065d
Author: Benedikt Ritter <britter@apache.org>
Date:   2017-02-06T18:54:40Z

    Make Checkstyle happy

commit ef6a391006ab1fa672dc26fc234b6411a7dfa888
Author: Benedikt Ritter <britter@apache.org>
Date:   2017-02-06T18:54:59Z

    Configure shade plugin so that is does not explode

----


> JUnit 5 surefire-provider code donation
> ---------------------------------------
>
>                 Key: SUREFIRE-1330
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1330
>             Project: Maven Surefire
>          Issue Type: Task
>            Reporter: Benedikt Ritter
>             Fix For: 3.0-RC1
>
>         Attachments: junit-platform-surefire-provider.zip
>
>
> The JUnit team wishes to contribute their surefire provider implementation for JUnit
5 to the Maven team.
> The code is currently located at GitHub: https://github.com/junit-team/junit5/tree/master/junit-platform-surefire-provider
> They have recently relicensed the code under terms of Apache License 2.0: https://github.com/junit-team/junit5/issues/541



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message