maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MSHARED-607) Simplify UrlValidationUtil to modern rules
Date Sat, 07 Jan 2017 13:04:58 GMT

    [ https://issues.apache.org/jira/browse/MSHARED-607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15807473#comment-15807473
] 

Hudson commented on MSHARED-607:
--------------------------------

SUCCESS: Integrated in Jenkins build maven-shared Jigsaw #671 (See [https://builds.apache.org/job/maven-shared%20Jigsaw/671/])
[MSHARED-607] Simplify UrlValidationUtil to modern rules

* Remove custom patterns and use default (builtin) ones
* Adapt tests where .local is not valid anymore by retaining the test idea itself (michaelo:
[http://svn.apache.org/viewvc/?view=rev&rev=1777776])
* (edit) maven-reporting-impl/src/main/java/org/apache/maven/reporting/UrlValidationUtil.java
* (edit) maven-reporting-impl/src/test/java/org/apache/maven/reporting/UrlValidationUtilTest.java


> Simplify UrlValidationUtil to modern rules
> ------------------------------------------
>
>                 Key: MSHARED-607
>                 URL: https://issues.apache.org/jira/browse/MSHARED-607
>             Project: Maven Shared Components
>          Issue Type: Improvement
>          Components: maven-reporting-impl
>    Affects Versions: maven-reporting-impl 2.4
>            Reporter: Michael Osipov
>            Assignee: Michael Osipov
>             Fix For: maven-reporting-impl 3.0
>
>
> The util was written years where some stuff did not exist (like IPv6) and some stuff
was allowed which is discouraged and consider wrong (like {{.local}}).
> What can be cleaned up:
> * Use {{Validator}}'s default schemes, there is no reason to exclude {{ftp}}
> * Use default local URL validator
> * Drop support for {{.local}}, it is discouraged, a specially-reserved TLD for mDNS and
can cause issues on a heterogenous network.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message