maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Osipov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MSKINS-133) width, height and border values not used for banner display
Date Mon, 09 Jan 2017 07:35:58 GMT

    [ https://issues.apache.org/jira/browse/MSKINS-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15810935#comment-15810935
] 

Michael Osipov commented on MSKINS-133:
---------------------------------------

No, see https://svn.apache.org/repos/asf/maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/main/resources/org/apache/maven/doxia/siterenderer/resources/default-site-macros.vm

The macro {{banner}} is incomplete. Take a look at the Fluido Skin. It is complete. You need
to copy the code, test and you are done. I would move this to the appropriate project.

> width, height and border values not used for banner display
> -----------------------------------------------------------
>
>                 Key: MSKINS-133
>                 URL: https://issues.apache.org/jira/browse/MSKINS-133
>             Project: Maven Skins
>          Issue Type: Bug
>          Components: Default Skin
>    Affects Versions: default-1.2
>            Reporter: Michael Benz
>            Priority: Minor
>
> Similar to the issue MSKINS-16 that was fixed for the Fluido skin the Default Skin ignores
the width and height and border settings in the site descriptor.
> The changes in site.xml were introduced here:
> DOXIASITETOOLS-58
> {code}
> <bannerLeft>
> 	<name>Name</name>
> 	<src>Logo.svg</src>
> 	<width>30</width>
> 	<height>10</height>
> 	<title>Logo Title</title>
> 	<border>2</border>
> </bannerLeft>
> {code}
> Created HTML:
> {code}
> <img src="Logo.svg" alt="Name" title="Logo Title">
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message