maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SUREFIRE-1307) Provide a convenient way to run tests against multiple JUnit versions
Date Fri, 25 Nov 2016 07:12:58 GMT

    [ https://issues.apache.org/jira/browse/SUREFIRE-1307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695055#comment-15695055
] 

ASF GitHub Bot commented on SUREFIRE-1307:
------------------------------------------

GitHub user britter opened a pull request:

    https://github.com/apache/maven-surefire/pull/135

    SUREFIRE-1307: Provide a convenient way to run tests against multiple JUnit versions

    First proposal to run tests against multiple JUnit versions.
    
    I implemented an Enum representing the available JUnit versions. The Enum values know
how to configure the maven launcher in order to execute tests with that JUnit version. For
all 4.x versions this is simply done by setting the junit.version system property. For JUnit
5 and the JUnit 5 vintage support, a profile needs to be activated.
    
    If this i going into the right direction, we can create a parent pom file with the profiles
and adopt this to more of the existing tests.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/britter/maven-surefire SUREFIRE-1307

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven-surefire/pull/135.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #135
    
----
commit 108538bae9fd5957aea47135f232ac2529167ff8
Author: Benedikt Ritter <britter@apache.org>
Date:   2016-10-09T12:30:49Z

    Remove unused property

commit 8995a2894488d6ca3796f274498b1516cd2ed131
Author: Benedikt Ritter <britter@apache.org>
Date:   2016-10-09T12:43:20Z

    Reuse Junit4VersionsIT to also test JUnit 5

commit 1ab033afb89c1646c64e4b95ed184179c1670c62
Author: Benedikt Ritter <britter@apache.org>
Date:   2016-10-09T12:51:55Z

    Add test using vintage engine

commit 81f3dda52af9805a46bab2e608c62ed1b0e6b9fd
Author: Benedikt Ritter <britter@apache.org>
Date:   2016-10-09T13:32:10Z

    Move share compiler configuration among projects

commit a50c823baba16f0bc5e4b7c08993d1bf706ce1dc
Author: Benedikt Ritter <britter@apache.org>
Date:   2016-10-10T17:04:24Z

    Sure one test among JUnit 4 and JUnit 5

commit 31b55924060c9b8994a28761c8d8722a6f1d491c
Author: Benedikt Ritter <britter@apache.org>
Date:   2016-10-10T17:27:26Z

    Introduce JUnitVersion enum for configuring tests for different junit versions

commit e4a5247a74ad95d4b79c074402c959414dfa2732
Author: Benedikt Ritter <britter@apache.org>
Date:   2016-11-22T20:16:37Z

    Move engines into plugin declaration

----


> Provide a convenient way to run tests against multiple JUnit versions
> ---------------------------------------------------------------------
>
>                 Key: SUREFIRE-1307
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1307
>             Project: Maven Surefire
>          Issue Type: Test
>            Reporter: Benedikt Ritter
>            Assignee: Tibor Digana
>             Fix For: junit5
>
>
> In order to make sure all feature that where working with the JUnit 4 proivder, we need
a way to execute the JUnit 4 integration tests also against the JUnit 5 provider.
> Provide a convenient way to execute existing tests against multiple JUnit versions. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message