[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15646327#comment-15646327
]
Hervé Boutemy commented on DOXIASITETOOLS-171:
----------------------------------------------
the change in generated specification version happened in Doxia Sitetools 1.7.2:
{noformat}$ for f in 1.7* ; do echo ; echo "* $f" ; unzip -p $f/doxia-site-renderer-$f.jar
META-INF/MANIFEST.MF ; done
* 1.7
Manifest-Version: 1.0
Implementation-Vendor: The Apache Software Foundation
Implementation-Title: Doxia :: Site Renderer
Implementation-Version: 1.7
Implementation-Vendor-Id: org.apache.maven.doxia
Built-By: herve
Build-Jdk: 1.7.0_71
Specification-Vendor: The Apache Software Foundation
Specification-Title: Doxia :: Site Renderer
Created-By: Apache Maven 3.3.9
Specification-Version: 1.7
Archiver-Version: Plexus Archiver
* 1.7.1
Manifest-Version: 1.0
Implementation-Vendor: The Apache Software Foundation
Implementation-Title: Doxia :: Site Renderer
Implementation-Version: 1.7.1
Implementation-Vendor-Id: org.apache.maven.doxia
Built-By: herve
Build-Jdk: 1.7.0_71
Specification-Vendor: The Apache Software Foundation
Specification-Title: Doxia :: Site Renderer
Created-By: Apache Maven 3.3.9
Specification-Version: 1.7.1
Archiver-Version: Plexus Archiver
* 1.7.2
Manifest-Version: 1.0
Implementation-Vendor: The Apache Software Foundation
Implementation-Title: Doxia :: Site Renderer
Implementation-Version: 1.7.2
Implementation-Vendor-Id: org.apache.maven.doxia
Built-By: herve
Build-Jdk: 1.7.0_71
Specification-Vendor: The Apache Software Foundation
Specification-Title: Doxia :: Site Renderer
Created-By: Apache Maven 3.4.0-SNAPSHOT
Implementation-URL: https://maven.apache.org/doxia/doxia-sitetools/dox
ia-site-renderer/
Specification-Version: 1.7
Archiver-Version: Plexus Archiver
* 1.7.3
Manifest-Version: 1.0
Implementation-Vendor: The Apache Software Foundation
Implementation-Title: Doxia :: Site Renderer
Implementation-Version: 1.7.3
Implementation-Vendor-Id: org.apache.maven.doxia
Built-By: herve
Build-Jdk: 1.7.0_71
Specification-Vendor: The Apache Software Foundation
Specification-Title: Doxia :: Site Renderer
Created-By: Apache Maven 3.4.0-SNAPSHOT
Implementation-URL: https://maven.apache.org/doxia/doxia-sitetools/dox
ia-site-renderer/
Specification-Version: 1.7
Archiver-Version: Plexus Archiver{noformat}
what caused this change?
and IIUC, MSHARED-191 is about avoiding {{-SNAPSHOT}} in specification version, not about
limiting version to 2 digits: or the title and description should be improved to match the
full implemented changes?
> DefaultSiteRenderer must use Package#getImplementationVersion to check for Doxia Sitetools
prerequisite
> -------------------------------------------------------------------------------------------------------
>
> Key: DOXIASITETOOLS-171
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-171
> Project: Maven Doxia Sitetools
> Issue Type: Bug
> Components: Site renderer
> Affects Versions: 1.7.3
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Fix For: 1.7.4
>
>
> Issue raised on the [mailing list|https://mail-archives.apache.org/mod_mbox/maven-dev/201611.mbox/%3CCAArU9iZJLoscR0VQw7%2BpTcXUwHLwjF%3Dva8MNLN-rn%2BEuMQGfCQ%40mail.gmail.com%3E]
with a [sample project|https://github.com/jieryn/fluido-fail] issue has been reproduced.
> The reason is that the prerequisite for the Sitetools are validated against:
> {code:java}
> Package p = DefaultSiteRenderer.class.getPackage();
> String current = ( p == null ) ? null : p.getSpecificationVersion();
> {code}
> but the specification for the value of {{SpecificationVersion}} is {{major.minor}}. This
was broken for some years and finally fixed with MSHARED-191. This likely creeped into the
module.
> Proposed patch:
> {code}
> Index: DefaultSiteRenderer.java
> ===================================================================
> --- DefaultSiteRenderer.java (revision 1768577)
> +++ DefaultSiteRenderer.java (working copy)
> @@ -803,7 +803,7 @@
> skinModel.getPrerequisites() == null ? null : skinModel.getPrerequisites().getDoxiaSitetools();
>
> Package p = DefaultSiteRenderer.class.getPackage();
> - String current = ( p == null ) ? null : p.getSpecificationVersion();
> + String current = ( p == null ) ? null : p.getImplementationVersion();
>
> if ( StringUtils.isNotBlank( toolsPrerequisite ) && ( current
!= null )
> && !matchVersion( current, toolsPrerequisite ) )
> {code}
> works flawlessly with the sample project.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
|