maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MPH-105) Effective pom aggregation is not triggered
Date Sun, 13 Nov 2016 00:06:59 GMT

    [ https://issues.apache.org/jira/browse/MPH-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15660512#comment-15660512
] 

Hudson commented on MPH-105:
----------------------------

SUCCESS: Integrated in Jenkins build maven-plugins #7626 (See [https://builds.apache.org/job/maven-plugins/7626/])
[MPH-105] Effective pom aggregation is not triggered

When the plugin is invoked from the command-line, always show all effective POMs for all projects
in the reactor. When it is invoked from the lifecycle, only show all effective POMs for the
head project in the reactor (see commit 497785 and resolution of MPH-21); otherwise, show
the effective POM for the current project only. (gboue: [http://svn.apache.org/viewvc/?view=rev&rev=1769446])
* (add) maven-help-plugin/src/it/effective-pom-from-lifecycle
* (add) maven-help-plugin/src/it/effective-pom-from-lifecycle/module
* (add) maven-help-plugin/src/it/effective-pom-from-lifecycle/module/pom.xml
* (add) maven-help-plugin/src/it/effective-pom-from-lifecycle/pom.xml
* (add) maven-help-plugin/src/it/effective-pom-from-lifecycle/verify.groovy
* (add) maven-help-plugin/src/it/effective-pom-multimodule
* (add) maven-help-plugin/src/it/effective-pom-multimodule-unlink-parent
* (add) maven-help-plugin/src/it/effective-pom-multimodule-unlink-parent/invoker.properties
* (add) maven-help-plugin/src/it/effective-pom-multimodule-unlink-parent/module
* (add) maven-help-plugin/src/it/effective-pom-multimodule-unlink-parent/module/pom.xml
* (add) maven-help-plugin/src/it/effective-pom-multimodule-unlink-parent/pom.xml
* (add) maven-help-plugin/src/it/effective-pom-multimodule-unlink-parent/verify.groovy
* (add) maven-help-plugin/src/it/effective-pom-multimodule/invoker.properties
* (add) maven-help-plugin/src/it/effective-pom-multimodule/module
* (add) maven-help-plugin/src/it/effective-pom-multimodule/module/pom.xml
* (add) maven-help-plugin/src/it/effective-pom-multimodule/pom.xml
* (add) maven-help-plugin/src/it/effective-pom-multimodule/verify.groovy
* (edit) maven-help-plugin/src/main/java/org/apache/maven/plugins/help/EffectivePomMojo.java


> Effective pom aggregation is not triggered
> ------------------------------------------
>
>                 Key: MPH-105
>                 URL: https://issues.apache.org/jira/browse/MPH-105
>             Project: Maven Help Plugin
>          Issue Type: Bug
>          Components: effective-pom
>    Affects Versions: 2.2
>         Environment: Maven 3.0.5
>            Reporter: Wisen Tanasa
>             Fix For: waiting-for-feedback
>
>         Attachments: MPH-105.patch
>
>
> Patch attached and contains JUnit.
> The bug is happening when it hits this portion and `projects.get( 0 ).equals( project
)` is returning false. In my JUnit, this is happening when a sub module's parent is not the
aggregator pom.
> EffectivePomMojo.java#90:
> {code}
> if ( projects.get( 0 ).equals( project ) && projects.size() > 1 )
> {code}
> Is the first check really necessary?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message