maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SUREFIRE-1293) Simplify org.apache.maven.plugin.surefire.report.TestSetRunListener by using the null object pattern
Date Wed, 12 Oct 2016 14:41:21 GMT

    [ https://issues.apache.org/jira/browse/SUREFIRE-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568908#comment-15568908
] 

ASF GitHub Bot commented on SUREFIRE-1293:
------------------------------------------

Github user Tibor17 commented on the issue:

    https://github.com/apache/maven-surefire/pull/127
  
    @britter 
    After using one integration tests only
    `<include>org/apache/**/JUnit47ParallelIT.java</include>`
    I got same errors as in Jenkins.
    I think the dependency `commons-lang3` is not propagated to the forked jvm. Maybe somewhere
some scope but not in our code.
    If you run the test and go to `target/surefire` you will see a jar file. Download it and
lookup `commons` in manifest.


> Simplify org.apache.maven.plugin.surefire.report.TestSetRunListener by using the null
object pattern
> ----------------------------------------------------------------------------------------------------
>
>                 Key: SUREFIRE-1293
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1293
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: Maven Surefire Plugin
>            Reporter: Benedikt Ritter
>            Assignee: Tibor Digana
>              Labels: github
>             Fix For: 2.19.2
>
>
> The class org.apache.maven.plugin.surefire.report.TestSetRunListener has a lot of checks
like this:
> {code:java}
> if( field != null )
> {
>     // do something with field
> }
> {code}
> This can be simplified by providing fallback implementations for the fields being used
by TestSetRunListener.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message