maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SUREFIRE-1293) Simplify org.apache.maven.plugin.surefire.report.TestSetRunListener by using the null object pattern
Date Wed, 12 Oct 2016 11:06:21 GMT

    [ https://issues.apache.org/jira/browse/SUREFIRE-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568415#comment-15568415
] 

Hudson commented on SUREFIRE-1293:
----------------------------------

UNSTABLE: Integrated in Jenkins build maven-surefire #1638 (See [https://builds.apache.org/job/maven-surefire/1638/])
[SUREFIRE-1293] Simplify (tibor17: rev fd9f6e5598e7ce6cdb4168ce15cf6ca138b7753f)
* (add) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/NullStatelessXmlReporter.java
* (add) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/NullConsoleReporter.java
* (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/runorder/StatisticsReporter.java
* (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/DefaultReporterFactory.java
* (add) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/NullFileReporter.java
* (add) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/NullConsoleOutputReceiver.java
* (add) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/NullStatisticsReporter.java
* (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetRunListener.java


> Simplify org.apache.maven.plugin.surefire.report.TestSetRunListener by using the null
object pattern
> ----------------------------------------------------------------------------------------------------
>
>                 Key: SUREFIRE-1293
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1293
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: Maven Surefire Plugin
>            Reporter: Benedikt Ritter
>            Assignee: Tibor Digana
>              Labels: github
>             Fix For: 2.19.2
>
>
> The class org.apache.maven.plugin.surefire.report.TestSetRunListener has a lot of checks
like this:
> {code:java}
> if( field != null )
> {
>     // do something with field
> }
> {code}
> This can be simplified by providing fallback implementations for the fields being used
by TestSetRunListener.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message