maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Plamen Totev (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MASSEMBLY-833) Ability to ignore errors about no files to package in assembly
Date Mon, 31 Oct 2016 20:14:59 GMT

    [ https://issues.apache.org/jira/browse/MASSEMBLY-833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15623230#comment-15623230
] 

Plamen Totev commented on MASSEMBLY-833:
----------------------------------------

[~gboue], just to mention that the archivers themselves can add  finalizers(and some of them
are adding real not virtual files). For example {{AbstractArchiver}} adds {{DotDirectiveArchiveFinalizer}}
if {{dotFileDirectory}} is set. {{DotDirectiveArchiveFinalizer#getVirtualFiles}} returns empty
list because it adds real files (directories stored in {{.plxarc}}) file. So I'm not completely
sure if there is reliable method outside {{AbstractArchiver}} to check if the archive is going
to be empty. 

Of course since the assembly plugin have quite a lot of control over the {{Archiver}} configuration
I guess it's safe to say there are no added extra finalizers apart the ones added by the plugin
itself. I just wanted to mention that just in case :)

> Ability to ignore errors about no files to package in assembly
> --------------------------------------------------------------
>
>                 Key: MASSEMBLY-833
>                 URL: https://issues.apache.org/jira/browse/MASSEMBLY-833
>             Project: Maven Assembly Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.6
>            Reporter: Martin Vehovsk√Ĺ
>         Attachments: _MASSEMBLY_833__added_ignoreNoFiles_parameter_allowing_not_to_fail_when_there_are_no_files.patch
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> Motivation: Having extremely large multi-module project, some modules lets call them
"application" modules provide "configuration" files, and they provide them for different environments.
Problem is that not all "application" modules provide "configuration" files for all environments.
In case there are no files available for assembly, the single goal ends up with ERROR:
> Failed to
>  create assembly: Error creating assembly archive <assembly_name>: You must set
at least one file.
> Available workaround is to specify a property to by default skip the assembly execution
and only if there are files for given environment set this property to not skip the given
assembly execution.
> However for large number of environments this solution starts to be messy and hard to
maintain.
> Do you think that having assembly Parameter "ignoreNoFiles" that will cause to skip the
archive creation for cases there are no files to package seems like reasonable solution?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message