maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Summers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WAGON-461) URL string not properly encoded by webdav
Date Tue, 16 Aug 2016 13:20:20 GMT

    [ https://issues.apache.org/jira/browse/WAGON-461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422713#comment-15422713
] 

Mike Summers commented on WAGON-461:
------------------------------------

I did, debug didn't reveal anything- there's not much logging in Jackrabbit.

I added some debug logging to my local copy of the source and it shows that the URI is not
encoded at the point that it instantiates MkColMethod which leads directly to the HttpClient
problem.

The double encoding is a puzzle. Why adding the encode on the call to MkColMethod doesn't
break is also odd.

As soon as I can I'll add two tests to the test suite, 1) URI with spaces, and 2) URI with
encoded spaces- that should help with the puzzle.

Thanks for your help.

> URL string not properly encoded by webdav
> -----------------------------------------
>
>                 Key: WAGON-461
>                 URL: https://issues.apache.org/jira/browse/WAGON-461
>             Project: Maven Wagon
>          Issue Type: Bug
>          Components: wagon-webdav
>    Affects Versions: 2.10
>         Environment: All
>            Reporter: Mike Summers
>
> wagon-webdav is not calling EncodingUtil prior to instantiating MkColMethod which results
in
> {code:java}
> Caused by: java.lang.IllegalArgumentException: Invalid uri 'https://snafu.sharefile-webdav.com/Shared
Folders/Fit - Expert Services/IBM/': escaped absolute path not valid
> {code}
> when there are special characters in the URI string.
> Changing line 153 of org.apache.maven.wagon.providers.webdav.WebDavWagon from
> {code:java}
>             method = new MkColMethod( url );
> {code}
> to
> {code:java}
>             method = new MkColMethod( EncodingUtil.encodeURLToString( url ) );
> {code}
> solves the issue although you may want to fix it elsewhere in the flow.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message