maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Osipov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MSITE-782) Support for custom Velocity tools has disappeared
Date Wed, 03 Aug 2016 21:45:20 GMT

    [ https://issues.apache.org/jira/browse/MSITE-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406676#comment-15406676
] 

Michael Osipov commented on MSITE-782:
--------------------------------------

This is a regression. The Velocity Toolbox configuration is is horribly complex, completely
overdesigned and has so many defaults a regular user wouldn't think of. By default, the [{{ConfiguationUtils}}|https://github.com/apache/velocity-tools/blob/49282b4dbb0b8f460a07db8e7e56844c05b908ce/velocity-tools-generic/src/main/java/org/apache/velocity/tools/config/ConfigurationUtils.java]
queries numerous sources for a {{tools.xml}}. Since the {{ToolManager}} is called with {{false,
false}} all automagic has been disabled. Your config is ignored.

I just quickly reviewed the Velocity code and as far as I can see, one can chain configs.
Your config would be a child, though I would not read from {{classpath:/tools.xml}} but rather
from {{classpath:/META-INF/maven/site-tools.xml}} or similar.

[~hboutemy], we need to create a new ticket where we will introduce a skin-related custom
Velocity Toolbox, document the new path and push a new Doxia release. This ticket would depend
on it. I will take care of the new ticket. Additionally, I do not know wether it makes sense
to configure the config path in {{skin.xml}}. I would like avoid too much config for this.

[~Bernardo-MG], please prepare a sample project to reproduce and to develop with. You may
also prepare a new branch of your skin with  a yet-to-be-announced default path for a tools
config file.

> Support for custom Velocity tools has disappeared
> -------------------------------------------------
>
>                 Key: MSITE-782
>                 URL: https://issues.apache.org/jira/browse/MSITE-782
>             Project: Maven Site Plugin
>          Issue Type: Bug
>    Affects Versions: 3.5, 3.5.1
>            Reporter: Bernardo
>
> Since the version 3.5 any skin using custom velocity tools is no longer working.
> This can be seen on the Reflow maven skin, and also on my own skin, which was developed
from the Reflow one.
> The Reflow skin, along its Velocity tools, can be found here:
> https://github.com/andriusvelykis/reflow-maven-skin
> My Maven skin can be found here:
> https://github.com/Bernardo-MG/docs-maven-skin
> My custom velocity tools:
> https://github.com/Bernardo-MG/maven-site-fixer
> All these projects are available through Maven central, making them easy to test.
> To see this problem just use the Reflow skin, which won't print the content of any page.
In the case of my own skin, there will be several errors in the HTML code, the most visible
being the broken headers.
> It may be actually a Doxia problem, related to this issue:
> https://issues.apache.org/jira/browse/DOXIASITETOOLS-93
> Additionally, there is a related link commenting this problem:
> http://maven.40175.n5.nabble.com/New-maven-site-and-doxia-with-custom-velocity-doxia-td5865376.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message