maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MDEPLOY-212) deploy-file incorrectly deploys attached artifacts
Date Sun, 07 Aug 2016 14:34:20 GMT

    [ https://issues.apache.org/jira/browse/MDEPLOY-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15410957#comment-15410957
] 

Hudson commented on MDEPLOY-212:
--------------------------------

SUCCESS: Integrated in maven-plugins #7129 (See [https://builds.apache.org/job/maven-plugins/7129/])
[MDEPLOY-212] deploy-file incorrectly deploys attached artifacts
[MDEPLOY-213] deploy-file replaces main artifact of a project

The deploy-file Mojo now creates a new MavenProject and attaches to this project all artifacts
to deploy. This also fixes the use of deprecated code from ArtifactFactory. (gboue: [http://svn.apache.org/viewvc/?view=rev&rev=1755441])
* maven-deploy-plugin/src/it/3rd-party-pom-with-extras
* maven-deploy-plugin/src/it/3rd-party-pom-with-extras/invoker.properties
* maven-deploy-plugin/src/it/3rd-party-pom-with-extras/pom.xml
* maven-deploy-plugin/src/it/3rd-party-pom-with-extras/test-0.1-src.tar.gz
* maven-deploy-plugin/src/it/3rd-party-pom-with-extras/test-0.1.pom
* maven-deploy-plugin/src/it/3rd-party-pom-with-extras/test-0.1.tar.gz
* maven-deploy-plugin/src/it/3rd-party-pom-with-extras/test-0.1.zip
* maven-deploy-plugin/src/it/3rd-party-pom-with-extras/test.properties
* maven-deploy-plugin/src/it/3rd-party-pom-with-extras/verify.bsh
* maven-deploy-plugin/src/it/MDEPLOY-212
* maven-deploy-plugin/src/it/MDEPLOY-212/invoker.properties
* maven-deploy-plugin/src/it/MDEPLOY-212/pom.xml
* maven-deploy-plugin/src/it/MDEPLOY-212/src
* maven-deploy-plugin/src/it/MDEPLOY-212/src/main
* maven-deploy-plugin/src/it/MDEPLOY-212/src/main/java
* maven-deploy-plugin/src/it/MDEPLOY-212/src/main/java/org
* maven-deploy-plugin/src/it/MDEPLOY-212/src/main/java/org/apache
* maven-deploy-plugin/src/it/MDEPLOY-212/src/main/java/org/apache/maven
* maven-deploy-plugin/src/it/MDEPLOY-212/src/main/java/org/apache/maven/test
* maven-deploy-plugin/src/it/MDEPLOY-212/src/main/java/org/apache/maven/test/HelloWorld.java
* maven-deploy-plugin/src/it/MDEPLOY-212/test-1.0.tar.gz
* maven-deploy-plugin/src/it/MDEPLOY-212/test-1.0.zip
* maven-deploy-plugin/src/it/MDEPLOY-212/verify.bsh
* maven-deploy-plugin/src/it/MDEPLOY-213
* maven-deploy-plugin/src/it/MDEPLOY-213/invoker.properties
* maven-deploy-plugin/src/it/MDEPLOY-213/pom.xml
* maven-deploy-plugin/src/it/MDEPLOY-213/src
* maven-deploy-plugin/src/it/MDEPLOY-213/src/main
* maven-deploy-plugin/src/it/MDEPLOY-213/src/main/java
* maven-deploy-plugin/src/it/MDEPLOY-213/src/main/java/org
* maven-deploy-plugin/src/it/MDEPLOY-213/src/main/java/org/apache
* maven-deploy-plugin/src/it/MDEPLOY-213/src/main/java/org/apache/maven
* maven-deploy-plugin/src/it/MDEPLOY-213/src/main/java/org/apache/maven/test
* maven-deploy-plugin/src/it/MDEPLOY-213/src/main/java/org/apache/maven/test/HelloWorld.java
* maven-deploy-plugin/src/it/MDEPLOY-213/test-1.0.tar.gz
* maven-deploy-plugin/src/it/MDEPLOY-213/test-1.0.zip
* maven-deploy-plugin/src/it/MDEPLOY-213/verify.bsh
* maven-deploy-plugin/src/main/java/org/apache/maven/plugins/deploy/DeployFileMojo.java
* maven-deploy-plugin/src/test/java/org/apache/maven/plugins/deploy/DeployFileMojoTest.java


> deploy-file incorrectly deploys attached artifacts
> --------------------------------------------------
>
>                 Key: MDEPLOY-212
>                 URL: https://issues.apache.org/jira/browse/MDEPLOY-212
>             Project: Maven Deploy Plugin
>          Issue Type: Bug
>          Components: deploy:deploy-file
>    Affects Versions: 2.8.2
>            Reporter: Brian Oliver
>            Assignee: Guillaume Boué
>            Priority: Critical
>             Fix For: 3.0.0
>
>
> When using the deploy-file goal in a Maven pom (not from the command-line), the deploy-file
goal will attempt to additionally deploy all attached artifacts, instead of the individually
specified file.
> The point of the deploy-file goal is to deploy the specified artifact and optionally
the specified source, javadoc and other classified files.   
> Due to this issue it will unfortunately attempt to deploy other artifacts, like -test.jars
that may have been generated.
> The following lines in DeployFileMojo should be conditional, perhaps based on a property
"includeAttachedArtifacts".
> {code}
>         List<Artifact> attachedArtifacts = project.getAttachedArtifacts();
>         for ( Artifact attached : attachedArtifacts )
>         {
>             deployableArtifacts.add( attached );
>         }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message