Mailing-List: contact issues-help@maven.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@maven.apache.org
Date: Fri, 20 May 2016 00:58:12 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@maven.apache.org
Message-ID: <JIRA.12971111.1463656063000.243055.1463705892821@Atlassian.JIRA>
In-Reply-To: <JIRA.12971111.1463656063000@Atlassian.JIRA>
References: <JIRA.12971111.1463656063000@Atlassian.JIRA> <JIRA.12971111.1463656063842@arcas>
Subject: [jira] [Commented] (MNG-6025) Add a ProjectArtifactsCache similar
 to PluginArtifactsCache
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 20 May 2016 00:58:14 -0000


    [ https://issues.apache.org/jira/browse/MNG-6025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15292489#comment-15292489 ] 

ASF GitHub Bot commented on MNG-6025:
-------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/maven/pull/82


> Add a ProjectArtifactsCache similar to PluginArtifactsCache
> -----------------------------------------------------------
>
>                 Key: MNG-6025
>                 URL: https://issues.apache.org/jira/browse/MNG-6025
>             Project: Maven
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 3.3.9
>            Reporter: Anton Tanasenko
>            Priority: Minor
>
> Every mojo execution, if it specifies dependency resolution other than 'none', will cause a resolution to be performed.
> There is a guard in MojoExecutor's DependencyContext which guards against performing this resolution multiple times by looking at the changes to dependencyArtifacts list.
> However, during a build in an incremental/interactive environment, like eclipse m2e or maven console, those mojos might be executed at an arbitrary time and will not benefit from that DependencyContext check.
> I propose having a ProjectArtifactsCache (very similar to PluginArtifactsCache) that will cache artifact set as returned by LifecycleDependencyResolver#getDependencies().
> While it does not improve cli builds, incremental/interactive builds will receive a huge performance boost between pom changes.
> I've been able to get build of a project with a lot of dependencies (jenkins plugin) and a number of (fully incremental) mojo executions from 7 seconds to around 1.5 on a single java file change in eclipse m2e after introducing this cache.
> I will provide a patch shortly.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)