maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MNG-6025) Add a ProjectArtifactsCache similar to PluginArtifactsCache
Date Thu, 19 May 2016 11:11:12 GMT

    [ https://issues.apache.org/jira/browse/MNG-6025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290911#comment-15290911
] 

ASF GitHub Bot commented on MNG-6025:
-------------------------------------

GitHub user atanasenko opened a pull request:

    https://github.com/apache/maven/pull/82

    [MNG-6025] Add a ProjectArtifactsCache similar to PluginArtifactsCache

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/atanasenko/maven mng6025

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven/pull/82.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #82
    
----
commit 2d0ac1feec7dce0b5d278cfda0ae3df5110dde43
Author: Anton Tanasenko <atg.sleepless@gmail.com>
Date:   2016-05-18T15:40:28Z

    [MNG-6025] Add a ProjectArtifactsCache similar to PluginArtifactsCache

----


> Add a ProjectArtifactsCache similar to PluginArtifactsCache
> -----------------------------------------------------------
>
>                 Key: MNG-6025
>                 URL: https://issues.apache.org/jira/browse/MNG-6025
>             Project: Maven
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 3.3.9
>            Reporter: Anton Tanasenko
>            Priority: Minor
>
> Every mojo execution, if it specifies dependency resolution other than 'none', will cause
a resolution to be performed.
> There is a guard in MojoExecutor's DependencyContext which guards against performing
this resolution multiple times by looking at the changes to dependencyArtifacts list.
> However, during a build in an incremental/interactive environment, like eclipse m2e or
maven console, those mojos might be executed at an arbitrary time and will not benefit from
that DependencyContext check.
> I propose having a ProjectArtifactsCache (very similar to PluginArtifactsCache) that
will cache artifact set as returned by LifecycleDependencyResolver#getDependencies().
> While it does not improve cli builds, incremental/interactive builds will receive a huge
performance boost between pom changes.
> I've been able to get build of a project with a lot of dependencies (jenkins plugin)
and a number of (fully incremental) mojo executions from 7 seconds to around 1.5 on a single
java file change in eclipse m2e after introducing this cache.
> I will provide a patch shortly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message